mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: Fixes send_blocks_and_test docs

Browse Source 
It's not true that if success=False the tip doesn't advance. It doesn'test
advance to the provided tip, but it can advance to a competing one
This commit is contained in:
Sergi Delgado Segura committed 2025-07-28 10:15:17 -04:00
1 parent 09c95f21e7
commit 0465574c12
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
test/functional/test_framework/p2p.py
+2 -2
View File
@@ -866,8 +866,8 @@ class P2PDataStore(P2PInterface):
- the on_getheaders handler will ensure that any getheaders are responded to - the on_getheaders handler will ensure that any getheaders are responded to
- if force_send is False: wait for getdata for each of the blocks. The on_getdata handler will - if force_send is False: wait for getdata for each of the blocks. The on_getdata handler will
ensure that any getdata messages are responded to. Otherwise send the full block unsolicited. ensure that any getdata messages are responded to. Otherwise send the full block unsolicited.
- if success is True: assert that the node's tip advances to the most recent block - if success is True: assert that the node's tip is the last block in blocks at the end of the operation.
- if success is False: assert that the node's tip doesn't advance - if success is False: assert that the node's tip isn't the last block in blocks at the end of the operation
- if reject_reason is set: assert that the correct reject message is logged""" - if reject_reason is set: assert that the correct reject message is logged"""
with p2p_lock: with p2p_lock: