mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fuzz: mini_miner_selection fixups.

Browse Source 
Delete asserts that are redundant with the == assert.
Add assertion that the coinbase isn't already in mock_template_txids.
This commit is contained in:
glozow committed 2024-07-09 17:22:57 +01:00
1 parent de273d5300
commit 09370529fb
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
src/test/fuzz/mini_miner.cpp
+3 -3
View File
@@ -188,9 +188,9 @@ FUZZ_TARGET(mini_miner_selection, .init = initialize_miner)
auto mock_template_txids = mini_miner.GetMockTemplateTxids(); auto mock_template_txids = mini_miner.GetMockTemplateTxids();
// MiniMiner doesn't add a coinbase tx. // MiniMiner doesn't add a coinbase tx.
assert(mock_template_txids.count(blocktemplate->block.vtx[0]->GetHash()) == 0); assert(mock_template_txids.count(blocktemplate->block.vtx[0]->GetHash()) == 0);
mock_template_txids.emplace(blocktemplate->block.vtx[0]->GetHash()); auto [iter, new_entry] = mock_template_txids.emplace(blocktemplate->block.vtx[0]->GetHash());
assert(mock_template_txids.size() <= blocktemplate->block.vtx.size()); assert(new_entry);
assert(mock_template_txids.size() >= blocktemplate->block.vtx.size());
assert(mock_template_txids.size() == blocktemplate->block.vtx.size()); assert(mock_template_txids.size() == blocktemplate->block.vtx.size());
for (const auto& tx : blocktemplate->block.vtx) { for (const auto& tx : blocktemplate->block.vtx) {
assert(mock_template_txids.count(tx->GetHash())); assert(mock_template_txids.count(tx->GetHash()));