p2p: Avoid an IsAncestorOfBestHeaderOrTip call
Just don't call this function when it won't have any effect. Note that we can't remove the LookupBlockIndex call, since `last_received_header` is needed to check if new headers were received (`received_new_header`).
This commit is contained in:
1 parent
25c45bb0d0
commit
0bf6139e19
1 file changed
+1
-3
@@ -2919,9 +2919,7 @@ void PeerManagerImpl::ProcessHeadersMessage(CNode& pfrom, Peer& peer,
|
|||||||
{
|
{
|
||||||
LOCK(cs_main);
|
LOCK(cs_main);
|
||||||
last_received_header = m_chainman.m_blockman.LookupBlockIndex(headers.back().GetHash());
|
last_received_header = m_chainman.m_blockman.LookupBlockIndex(headers.back().GetHash());
|
||||||
if (IsAncestorOfBestHeaderOrTip(last_received_header)) {
|
already_validated_work = already_validated_work || IsAncestorOfBestHeaderOrTip(last_received_header);
|
||||||
already_validated_work = true;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// If our peer has NetPermissionFlags::NoBan privileges, then bypass our
|
// If our peer has NetPermissionFlags::NoBan privileges, then bypass our
|
||||||
|
|||||||
Reference in new issue
Block a user