mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang-tidy: Fix performance-no-automatic-move in headers

Browse Source 
See https://clang.llvm.org/extra/clang-tidy/checks/performance/no-automatic-move.html
This commit is contained in:
Hennadii Stepanov committed 2023-01-18 15:47:06 +00:00
1 parent 0a5dc030b9
commit 1308b837dc
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
src/script/miniscript.h
+2 -2
View File
@@ -1378,7 +1378,7 @@ inline NodeRef<Key> Parse(Span<const char> in, const Ctx& ctx)
assert(constructed.size() == 1); assert(constructed.size() == 1);
assert(constructed[0]->ScriptSize() == script_size); assert(constructed[0]->ScriptSize() == script_size);
if (in.size() > 0) return {}; if (in.size() > 0) return {};
const NodeRef<Key> tl_node = std::move(constructed.front()); NodeRef<Key> tl_node = std::move(constructed.front());
tl_node->DuplicateKeyCheck(ctx); tl_node->DuplicateKeyCheck(ctx);
return tl_node; return tl_node;
} }
@@ -1813,7 +1813,7 @@ inline NodeRef<Key> DecodeScript(I& in, I last, const Ctx& ctx)
} }
} }
if (constructed.size() != 1) return {}; if (constructed.size() != 1) return {};
const NodeRef<Key> tl_node = std::move(constructed.front()); NodeRef<Key> tl_node = std::move(constructed.front());
tl_node->DuplicateKeyCheck(ctx); tl_node->DuplicateKeyCheck(ctx);
// Note that due to how ComputeType works (only assign the type to the node if the // Note that due to how ComputeType works (only assign the type to the node if the
// subs' types are valid) this would fail if any node of tree is badly typed. // subs' types are valid) this would fail if any node of tree is badly typed.