mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

psbt: Fix PSBTInputSignedAndVerified bounds assert

Browse Source 
The previous `assert` used `>=`, allowing `input_index == psbt.inputs.size()` and out-of-bounds access in `psbt.inputs[input_index]`.

Found during review: https://github.com/bitcoin/bitcoin/pull/31650#discussion_r2685892867
This commit is contained in:
Lőrinc committed 2026-01-13 12:58:53 +01:00
1 parent 3c8d389a84
commit 2f5b1c5f80
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
src/psbt.cpp
+1 -1
View File
@@ -325,7 +325,7 @@ bool PSBTInputSigned(const PSBTInput& input)
bool PSBTInputSignedAndVerified(const PartiallySignedTransaction psbt, unsigned int input_index, const PrecomputedTransactionData* txdata) bool PSBTInputSignedAndVerified(const PartiallySignedTransaction psbt, unsigned int input_index, const PrecomputedTransactionData* txdata)
{ {
CTxOut utxo; CTxOut utxo;
assert(psbt.inputs.size() >= input_index); assert(input_index < psbt.inputs.size());
const PSBTInput& input = psbt.inputs[input_index]; const PSBTInput& input = psbt.inputs[input_index];
if (input.non_witness_utxo) { if (input.non_witness_utxo) {