mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wallet: GetLabelAddresses requires cs_wallet lock

Browse Source 
No change in behavior, the lock is already held at call sites.
This commit is contained in:
João Barbosa committed 2021-09-03 18:28:12 +01:00
1 parent 5fb6701bdb
commit 32d036e8da
2 files changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/wallet/wallet.cpp
+1 -1
View File
@@ -2191,7 +2191,7 @@ void CWallet::MarkDestinationsDirty(const std::set<CTxDestination>& destinations
std::set<CTxDestination> CWallet::GetLabelAddresses(const std::string& label) const std::set<CTxDestination> CWallet::GetLabelAddresses(const std::string& label) const
{ {
LOCK(cs_wallet); AssertLockHeld(cs_wallet);
std::set<CTxDestination> result; std::set<CTxDestination> result;
for (const std::pair<const CTxDestination, CAddressBookData>& item : m_address_book) for (const std::pair<const CTxDestination, CAddressBookData>& item : m_address_book)
{ {
src/wallet/wallet.h
+1 -1
View File
@@ -630,7 +630,7 @@ public:
int64_t GetOldestKeyPoolTime() const; int64_t GetOldestKeyPoolTime() const;
std::set<CTxDestination> GetLabelAddresses(const std::string& label) const; std::set<CTxDestination> GetLabelAddresses(const std::string& label) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
/** /**
* Marks all outputs in each one of the destinations dirty, so their cache is * Marks all outputs in each one of the destinations dirty, so their cache is