Merge bitcoin/bitcoin#24111: build: force CRCCheck in Windows installer
b3ccf26df4build: force CRCCheck in Windows installer (fanquake) Pull request description: Otherwise a user can pass `/NCRC` on the command line and bypass the CRC check, meaning they could use a corrupted installer. I can't think of a reason why we'd want to allow the use of corrupted installers. [NSIS docs](https://nsis.sourceforge.io/Docs/Chapter4.html#acrccheck): > Specifies whether or not the installer will perform a CRC on itself before allowing an install. Note that if the user uses /NCRC on the command line when executing the installer, and you didn't specify 'force', the CRC will not occur, and the user will be allowed to install a (potentially) corrupted installer. ACKs for top commit: hebasto: ACKb3ccf26df4, I have reviewed the code and it looks OK, I agree it can be merged. prusnak: utACKb3ccf26df4Tree-SHA512: 6b3c151bfd896dbf1a4af26114aec1721e4d4e6dad89eef796cd754c988b1bb03fd9a3f9889be3c754ff5b1cd7bf5bbfc126876c76038205c17807daff029319
This commit is contained in:
1 file changed
+1
-1
+1
-1
@@ -53,7 +53,7 @@ Var StartMenuGroup
|
|||||||
|
|
||||||
# Installer attributes
|
# Installer attributes
|
||||||
InstallDir $PROGRAMFILES64\Bitcoin
|
InstallDir $PROGRAMFILES64\Bitcoin
|
||||||
CRCCheck on
|
CRCCheck force
|
||||||
XPStyle on
|
XPStyle on
|
||||||
BrandingText " "
|
BrandingText " "
|
||||||
ShowInstDetails show
|
ShowInstDetails show
|
||||||
|
|||||||
Reference in new issue
Block a user