fuzz: RPC fuzzer post-merge follow-ups. Remove unused includes. Update list of fuzzed RPC commands.

This commit is contained in:
practicalswift committed 2021-04-28 09:27:50 +00:00
1 parent e45863166f
commit 54549dda31
1 file changed
+6 -8
+6 -8
View File
@@ -3,9 +3,7 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php. // file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <base58.h> #include <base58.h>
#include <chainparamsbase.h>
#include <core_io.h> #include <core_io.h>
#include <interfaces/chain.h>
#include <key.h> #include <key.h>
#include <key_io.h> #include <key_io.h>
#include <node/context.h> #include <node/context.h>
@@ -73,15 +71,16 @@ const std::vector<std::string> RPC_COMMANDS_NOT_SAFE_FOR_FUZZING{
#ifdef ENABLE_WALLET #ifdef ENABLE_WALLET
"dumpwallet", // avoid writing to disk "dumpwallet", // avoid writing to disk
#endif #endif
"echoipc", // avoid assertion failure (Assertion `"EnsureAnyNodeContext(request.context).init" && check' failed.) "echoipc", // avoid assertion failure (Assertion `"EnsureAnyNodeContext(request.context).init" && check' failed.)
"generatetoaddress", // avoid timeout "generatetoaddress", // avoid prohibitively slow execution (when `num_blocks` is large)
"gettxoutproof", // avoid slow execution "generatetodescriptor", // avoid prohibitively slow execution (when `nblocks` is large)
"gettxoutproof", // avoid prohibitively slow execution
#ifdef ENABLE_WALLET #ifdef ENABLE_WALLET
"importwallet", // avoid reading from disk "importwallet", // avoid reading from disk
"loadwallet", // avoid reading from disk "loadwallet", // avoid reading from disk
#endif #endif
"mockscheduler", // avoid assertion failure (Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed.)
"prioritisetransaction", // avoid signed integer overflow in CTxMemPool::PrioritiseTransaction(uint256 const&, long const&) (https://github.com/bitcoin/bitcoin/issues/20626) "prioritisetransaction", // avoid signed integer overflow in CTxMemPool::PrioritiseTransaction(uint256 const&, long const&) (https://github.com/bitcoin/bitcoin/issues/20626)
"savemempool", // disabled as a precautionary measure: may take a file path argument in the future
"setban", // avoid DNS lookups "setban", // avoid DNS lookups
"stop", // avoid shutdown state "stop", // avoid shutdown state
}; };
@@ -107,7 +106,6 @@ const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
"finalizepsbt", "finalizepsbt",
"generate", "generate",
"generateblock", "generateblock",
"generatetodescriptor",
"getaddednodeinfo", "getaddednodeinfo",
"getbestblockhash", "getbestblockhash",
"getblock", "getblock",
@@ -145,11 +143,11 @@ const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
"joinpsbts", "joinpsbts",
"listbanned", "listbanned",
"logging", "logging",
"mockscheduler",
"ping", "ping",
"preciousblock", "preciousblock",
"pruneblockchain", "pruneblockchain",
"reconsiderblock", "reconsiderblock",
"savemempool",
"scantxoutset", "scantxoutset",
"sendrawtransaction", "sendrawtransaction",
"setmocktime", "setmocktime",