Merge bitcoin/bitcoin#25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book
baa3ddc49cdoc: add release notes about `getreceivedbylabel` returning an error if the label is not in the address book. (furszy)8897a21658rpc: getreceivedbylabel, don't loop over the entire wallet txs map if no destinations were found for the input label. (furszy) Pull request description: Built on top of #23662, coming from comment https://github.com/bitcoin/bitcoin/pull/23662#pullrequestreview-971407999. If `wallet.GetLabelAddresses()` returns an empty vector (the wallet does not have stored destinations with that label in the addressbook) or if none of the returned destinations are from the wallet, we can return the function right away. Otherwise, we are walking through all the wallet txs + outputs for no reason (`output_scripts` is empty). ACKs for top commit: achow101: ACKbaa3ddc49ctheStack: re-ACKbaa3ddc49cw0xlt: ACK https://github.com/bitcoin/bitcoin/pull/25122/commits/baa3ddc49c46d00e3e0de06e494656f0f00b0ee8 Tree-SHA512: 00e10365b179bf008da2f3ef8fbb3ee04a330426374020e3f2d0151b16991baba4ef2b944e4659452f3e4d6cb20f128d0918ddf0453933a25a4d9fd8414a1911
This commit is contained in:
3 files changed
+22
-13
No files matched your search
@@ -85,6 +85,9 @@ Tools and Utilities
|
||||
Wallet
|
||||
------
|
||||
|
||||
- RPC `getreceivedbylabel` now returns an error, "Label not found
|
||||
in wallet" (-4), if the label is not in the address book. (#25122)
|
||||
|
||||
GUI changes
|
||||
-----------
|
||||
|
||||
|
||||
Reference in new issue
Block a user