interfaces, gui: Remove is_mine output parameter from getAddress

The is_mine output parameter is never used by any callers.
This commit is contained in:
Ava Chow committed 2025-08-19 10:16:57 -07:00
1 parent 22e689587a
commit 620abe985e
5 files changed
+9 -19

No files matched your search

+1 -9
View File
@@ -185,7 +185,6 @@ public:
}
bool getAddress(const CTxDestination& dest,
std::string* name,
isminetype* is_mine,
AddressPurpose* purpose) override
{
LOCK(m_wallet->cs_wallet);
@@ -194,16 +193,9 @@ public:
if (name) {
*name = entry->GetLabel();
}
std::optional<isminetype> dest_is_mine;
if (is_mine || purpose) {
dest_is_mine = m_wallet->IsMine(dest);
}
if (is_mine) {
*is_mine = *dest_is_mine;
}
if (purpose) {
// In very old wallets, address purpose may not be recorded so we derive it from IsMine
*purpose = entry->purpose.value_or(*dest_is_mine ? AddressPurpose::RECEIVE : AddressPurpose::SEND);
*purpose = entry->purpose.value_or(m_wallet->IsMine(dest) ? AddressPurpose::RECEIVE : AddressPurpose::SEND);
}
return true;
}