bugfix: disallow label for ranged descriptors & allow external non-ranged descriptors to have label

* do not only check user provided range data to decide whether descriptor is ranged
* properly handle std::optional<bool> when checking if descriptor is internal
This commit is contained in:
scgbckbone committed 2025-04-22 20:57:00 +02:00
1 parent e5a00b2497
commit 664657ed13
3 files changed
+20 -4

No files matched your search

+2 -1
View File
@@ -65,7 +65,8 @@ class WalletRescanUnconfirmed(BitcoinTestFramework):
assert tx_parent_to_reorg["txid"] in node.getrawmempool()
self.log.info("Import descriptor wallet on another node")
descriptors_to_import = [{"desc": w0.getaddressinfo(parent_address)['parent_desc'], "timestamp": 0, "label": "w0 import"}]
# descriptor is ranged - label not allowed
descriptors_to_import = [{"desc": w0.getaddressinfo(parent_address)['parent_desc'], "timestamp": 0}]
node.createwallet(wallet_name="w1", disable_private_keys=True)
w1 = node.get_wallet_rpc("w1")