depends: Avoid using helper variables in toolchain file

Using helper variables has two issues:
1. They contaminate the global namespace of the main build script.
2. They can be used as `set(var)`, effectively exposing a cache variable
`var`, which makes the toolchain file susceptible to the build
environment.
This commit is contained in:
Hennadii Stepanov committed 2025-05-07 17:02:53 +01:00
1 parent efac285a0d
commit 7343a1846c
1 file changed
+8 -10
+8 -10
View File
@@ -115,37 +115,35 @@ endif()
# Set configuration options for the main build system. # Set configuration options for the main build system.
set(qt_packages @qt_packages@) # The depends/Makefile can generate values with "not-set"
if("${qt_packages}" STREQUAL "") # semantics as empty strings or strings containing only spaces.
# Therefore, MATCHES must be used rather than STREQUAL.
if("@qt_packages@" MATCHES "^[ ]*$")
set(BUILD_GUI OFF CACHE BOOL "") set(BUILD_GUI OFF CACHE BOOL "")
else() else()
set(BUILD_GUI ON CACHE BOOL "") set(BUILD_GUI ON CACHE BOOL "")
set(Qt6_ROOT "${CMAKE_CURRENT_LIST_DIR}" CACHE PATH "") set(Qt6_ROOT "${CMAKE_CURRENT_LIST_DIR}" CACHE PATH "")
endif() endif()
set(qrencode_packages @qrencode_packages@) if("@qrencode_packages@" MATCHES "^[ ]*$")
if("${qrencode_packages}" STREQUAL "")
set(WITH_QRENCODE OFF CACHE BOOL "") set(WITH_QRENCODE OFF CACHE BOOL "")
else() else()
set(WITH_QRENCODE ON CACHE BOOL "") set(WITH_QRENCODE ON CACHE BOOL "")
endif() endif()
set(zmq_packages @zmq_packages@) if("@zmq_packages@" MATCHES "^[ ]*$")
if("${zmq_packages}" STREQUAL "")
set(WITH_ZMQ OFF CACHE BOOL "") set(WITH_ZMQ OFF CACHE BOOL "")
else() else()
set(WITH_ZMQ ON CACHE BOOL "") set(WITH_ZMQ ON CACHE BOOL "")
endif() endif()
set(wallet_packages @wallet_packages@) if("@wallet_packages@" MATCHES "^[ ]*$")
if("${wallet_packages}" STREQUAL "")
set(ENABLE_WALLET OFF CACHE BOOL "") set(ENABLE_WALLET OFF CACHE BOOL "")
else() else()
set(ENABLE_WALLET ON CACHE BOOL "") set(ENABLE_WALLET ON CACHE BOOL "")
endif() endif()
set(usdt_packages @usdt_packages@) if("@usdt_packages@" MATCHES "^[ ]*$")
if("${usdt_packages}" STREQUAL "")
set(WITH_USDT OFF CACHE BOOL "") set(WITH_USDT OFF CACHE BOOL "")
else() else()
set(WITH_USDT ON CACHE BOOL "") set(WITH_USDT ON CACHE BOOL "")