wallet: Remove unnecessary database Close step on shutdown

StopWallets, which was being called prior to UnloadWallets, performs an
unnecessary database closing step. This causes issues in UnloadWallets
which does additional database cleanups. Since the database closing step
is unnecessary, StopWallets is removed, and UnloadWallets is now called
from WalletLoaderImpl::stop.
This commit is contained in:
Ava Chow committed 2025-05-14 11:03:57 -07:00
1 parent 98a1a5275c
commit 876a2585a8
3 files changed
+2 -13

No files matched your search

+2 -2
View File
@@ -553,7 +553,7 @@ public:
m_context.chain = &chain;
m_context.args = &args;
}
~WalletLoaderImpl() override { UnloadWallets(m_context); }
~WalletLoaderImpl() override { stop(); }
//! ChainClient methods
void registerRpcs() override
@@ -574,7 +574,7 @@ public:
m_context.scheduler = &scheduler;
return StartWallets(m_context);
}
void stop() override { return StopWallets(m_context); }
void stop() override { return UnloadWallets(m_context); }
void setMockTime(int64_t time) override { return SetMockTime(time); }
void schedulerMockForward(std::chrono::seconds delta) override { Assert(m_context.scheduler)->MockForward(delta); }