mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#28184: lint: fix custom mypy cache dir setting

Browse Source 
f9047771d6 lint: fix custom mypy cache dir setting (Fabian Jahr)

Pull request description:

  fixes #28183

  The custom cache dir for `mypy` can only be set via an environment variable, setting the `MYPY_CACHE_DIR` variable in the program is not sufficient. This error was introduced while translating the shell script to python.

  See also the mypy documentation: https://mypy.readthedocs.io/en/stable/config_file.html#confval-cache_dir

ACKs for top commit:
  MarcoFalke:
    lgtm ACK f9047771d6

Tree-SHA512: 7e8fb0cd06688129bd46d1afb8647262eb53d0f60b1ef6f288fedaa122d906fb62c9855e8bb0d6c6297d41a87a47d3cec7a00df55a7d033947937dfe23d07ba7
This commit is contained in:
fanquake committed 2023-10-02 11:19:08 +02:00
2 parents f66af92f1a f9047771d6
commit 8b44d01118
1 file changed
+4 -1
Download Patch File Download Diff File Expand all files Collapse all files
test/lint/lint-python.py
+4 -1
View File
@@ -9,14 +9,17 @@ Check for specified flake8 and mypy warnings in python files.
""" """
import os import os
from pathlib import Path
import subprocess import subprocess
import sys import sys
from importlib.metadata import metadata, PackageNotFoundError from importlib.metadata import metadata, PackageNotFoundError
# Customize mypy cache dir via environment variable
cache_dir = Path(__file__).parent.parent / ".mypy_cache"
os.environ["MYPY_CACHE_DIR"] = str(cache_dir)
DEPS = ['flake8', 'lief', 'mypy', 'pyzmq'] DEPS = ['flake8', 'lief', 'mypy', 'pyzmq']
MYPY_CACHE_DIR = f"{os.getenv('BASE_ROOT_DIR', '')}/test/.mypy_cache"
# All .py files, except those in src/ (to exclude subtrees there) # All .py files, except those in src/ (to exclude subtrees there)
FLAKE_FILES_ARGS = ['git', 'ls-files', '*.py', ':!:src/*.py'] FLAKE_FILES_ARGS = ['git', 'ls-files', '*.py', ':!:src/*.py']