Merge bitcoin/bitcoin#30493: policy: enable full-rbf by default
590456e3f1policy: enable full-rbf by default (Peter Todd)195e98ea8edoc: add release notes for full-rbf (Peter Todd) Pull request description: This pull request enables full rbf (mempool policy) by default. #28132 was closed recently with this [comment](https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-2225369634). --- Rationale: - Full RBF config option was added in July 2022: https://github.com/bitcoin/bitcoin/pull/25353 - It is used regularly: https://mempool.space/rbf#fullrbf - Most mining pools are using it: https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-2059120917 ACKs for top commit: petertodd: ACK590456e3f1instagibbs: reACK https://github.com/bitcoin/bitcoin/pull/30493/commits/590456e3f1043ba0680e0afec9fd7653db1098bb glozow: reACK590456e3f1achow101: ACK590456e3f1ariard: tested ACK590456e3murchandamus: reACK590456e3f1Tree-SHA512: 83fceef9961021687e6ff979041f89be0c616f7a49cc28a5d7edf7d8ad064fcb9c0e2af0c31f4f89867a9f6dff4e40ef8ad4dbd624e7d6a4e00ac1f1c1f66c7a
This commit is contained in:
6 files changed
+15
-4
No files matched your search
@@ -119,6 +119,9 @@ class P2PPermissionsTests(BitcoinTestFramework):
|
||||
|
||||
self.log.debug("Check that node[1] will not send an invalid tx to node[0]")
|
||||
tx.vout[0].nValue += 1
|
||||
# add dust to cause policy rejection but no disconnection
|
||||
tx.vout.append(tx.vout[0])
|
||||
tx.vout[-1].nValue = 0
|
||||
txid = tx.rehash()
|
||||
# Send the transaction twice. The first time, it'll be rejected by ATMP because it conflicts
|
||||
# with a mempool transaction. The second time, it'll be in the m_lazy_recent_rejects filter.
|
||||
@@ -126,7 +129,7 @@ class P2PPermissionsTests(BitcoinTestFramework):
|
||||
[tx],
|
||||
self.nodes[1],
|
||||
success=False,
|
||||
reject_reason='{} (wtxid={}) from peer=0 was not accepted: txn-mempool-conflict'.format(txid, tx.getwtxid())
|
||||
reject_reason='{} (wtxid={}) from peer=0 was not accepted: dust'.format(txid, tx.getwtxid())
|
||||
)
|
||||
|
||||
p2p_rebroadcast_wallet.send_txs_and_test(
|
||||
|
||||
Reference in new issue
Block a user