From 9715d3bf1e4013476539f1523a6b54d2055c32c6 Mon Sep 17 00:00:00 2001
From: Andrew Toth <andrewstoth@gmail.com>
Date: Fri, 28 Jun 2024 16:19:17 -0400
Subject: [PATCH] refactor: encapsulate flags get access for all other checks

No behavior change. This prepares moving the cache entry
flags field to private access.
---
 src/coins.h              | 1 +
 src/test/coins_tests.cpp | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/coins.h b/src/coins.h
index 11ff7f4bce..df4d7a7883 100644
--- a/src/coins.h
+++ b/src/coins.h
@@ -131,6 +131,7 @@ struct CCoinsCacheEntry
     explicit CCoinsCacheEntry(Coin&& coin_) : coin(std::move(coin_)), flags(0) {}
     CCoinsCacheEntry(Coin&& coin_, unsigned char flag) : coin(std::move(coin_)), flags(flag) {}
 
+    inline unsigned char GetFlags() const noexcept { return flags; }
     inline bool IsDirty() const noexcept { return flags & DIRTY; }
     inline bool IsFresh() const noexcept { return flags & FRESH; }
 };
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp
index 3d415b3db4..1502595cbb 100644
--- a/src/test/coins_tests.cpp
+++ b/src/test/coins_tests.cpp
@@ -603,7 +603,7 @@ void GetCoinsMapEntry(const CCoinsMap& map, CAmount& value, char& flags, const C
         } else {
             value = it->second.coin.out.nValue;
         }
-        flags = it->second.flags;
+        flags = it->second.GetFlags();
         assert(flags != NO_ENTRY);
     }
 }