mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge #21394: [doc] Improve comment about protected peers

Browse Source 
ebde946a52 [doc] Improve comment about protected peers (Amiti Uttarwar)

Pull request description:

  The comment currently suggests a long-standing node would infrequently protect peers under normal circumstances. Clarify that we also protect peers that are synced to the same work as our chain tip. [Relevant check here](https://github.com/bitcoin/bitcoin/blob/ee0dc02c6f93de2a366bbff490eb4d37bca6a24f/src/net_processing.cpp#L1997).

ACKs for top commit:
  Empact:
    ACK https://github.com/bitcoin/bitcoin/pull/21394/commits/ebde946a527e50630df180c6565ea5bf8d2ab5aa
  jnewbery:
    ACK ebde946a52

Tree-SHA512: 3692f4098e95f935d801e0ee6bbd3a7c9480e66ca070a7c68ba79c4fc2e62377f5d37080c7b6a7d15ab617aaf4d3df9b26abc4f1b090d572ba46fdd092a6a64a
This commit is contained in:
fanquake committed 2021-03-12 13:11:10 +08:00
2 parents b972913c33 ebde946a52
commit a13a8cd8e3
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
src/net_processing.cpp
+1 -1
View File
@@ -557,7 +557,7 @@ struct CNodeState {
* - its connection type is IsBlockOnlyConn() == false * - its connection type is IsBlockOnlyConn() == false
* - it gave us a valid connecting header * - it gave us a valid connecting header
* - we haven't reached MAX_OUTBOUND_PEERS_TO_PROTECT_FROM_DISCONNECT yet * - we haven't reached MAX_OUTBOUND_PEERS_TO_PROTECT_FROM_DISCONNECT yet
* - it has a better chain than we have * - its chain tip has at least as much work as ours
* *
* CHAIN_SYNC_TIMEOUT: if a peer's best known block has less work than our tip, * CHAIN_SYNC_TIMEOUT: if a peer's best known block has less work than our tip,
* set a timeout CHAIN_SYNC_TIMEOUT seconds in the future: * set a timeout CHAIN_SYNC_TIMEOUT seconds in the future: