mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#25713: tidy: run clang-tidy in quiet mode

Browse Source 
3fe58a98d3 tidy: run clang-tidy in quiet mode (fanquake)

Pull request description:

  This should cut the amount of output by atleast half.

  ```bash
  /opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=bitcoin bitcoin/src/wallet/test/fuzz/coinselection.cpp
  278 warnings generated.
  Suppressed 278 warnings (278 in non-user code).
  Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
  ```
  becomes
  ```bash
  /opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=/bitcoin -quiet bitcoin/src/wallet/test/fuzz/coinselection.cpp
  278 warnings generated.
  ```

  See https://clang.llvm.org/extra/clang-tidy/.

  >   --quiet
  > Run clang-tidy in quiet mode. This suppresses
  > printing statistics about ignored warnings and
  > warnings treated as errors if the respective
  > options are specified.

  However the `run-clang-tidy` option is `-quiet`. See https://github.com/llvm/llvm-project/blob/f28c006a5895fc0e329fe15fead81e37457cb1d1/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py#L244.

ACKs for top commit:
  jamesob:
    ACK https://github.com/bitcoin/bitcoin/pull/25713/commits/3fe58a98d3406fc62f6dbbd8c0d58caefc69c9ae

Tree-SHA512: 936cfab09a78e71a4a2a2b3539087c1a95fe279923cc8c3f950c70924d6920dcd54b0da8b5493a1337c23a3b25834ab0db5a6b0c660c6e46d750f0fc966e7625
This commit is contained in:
MacroFake committed 2022-07-30 09:26:22 +02:00
2 parents 5871b5b5ab 3fe58a98d3
commit ab3db34836
1 file changed
+2 -1
Download Patch File Download Diff File Expand all files Collapse all files
ci/test/06_script_b.sh
+2 -1
View File
@@ -35,8 +35,9 @@ if [ "$RUN_FUNCTIONAL_TESTS" = "true" ]; then
fi fi
if [ "${RUN_TIDY}" = "true" ]; then if [ "${RUN_TIDY}" = "true" ]; then
set -eo pipefail
export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/src/" export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/src/"
CI_EXEC run-clang-tidy "${MAKEJOBS}" ( CI_EXEC run-clang-tidy -quiet "${MAKEJOBS}" ) | grep -C5 "error"
export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/" export P_CI_DIR="${BASE_BUILD_DIR}/bitcoin-$HOST/"
CI_EXEC "python3 ${DIR_IWYU}/include-what-you-use/iwyu_tool.py"\ CI_EXEC "python3 ${DIR_IWYU}/include-what-you-use/iwyu_tool.py"\
" src/compat"\ " src/compat"\