mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: don't check if the socket is valid in GetBindAddress()

Browse Source 
The socket is always valid (the underlying file descriptor is not
`INVALID_SOCKET`) when `GetBindAddress()` is called.
This commit is contained in:
Vasil Dimov committed 2023-08-24 14:40:02 +02:00
1 parent 5ac1a51ee5
commit aeac68d036
1 file changed
+4 -6
Download Patch File Download Diff File Expand all files Collapse all files
src/net.cpp
+4 -6
View File
@@ -427,12 +427,10 @@ static CAddress GetBindAddress(const Sock& sock)
CAddress addr_bind; CAddress addr_bind;
struct sockaddr_storage sockaddr_bind; struct sockaddr_storage sockaddr_bind;
socklen_t sockaddr_bind_len = sizeof(sockaddr_bind); socklen_t sockaddr_bind_len = sizeof(sockaddr_bind);
if (sock.Get() != INVALID_SOCKET) { if (!sock.GetSockName((struct sockaddr*)&sockaddr_bind, &sockaddr_bind_len)) {
if (!sock.GetSockName((struct sockaddr*)&sockaddr_bind, &sockaddr_bind_len)) { addr_bind.SetSockAddr((const struct sockaddr*)&sockaddr_bind);
addr_bind.SetSockAddr((const struct sockaddr*)&sockaddr_bind); } else {
} else { LogPrintLevel(BCLog::NET, BCLog::Level::Warning, "getsockname failed\n");
LogPrintLevel(BCLog::NET, BCLog::Level::Warning, "getsockname failed\n");
}
} }
return addr_bind; return addr_bind;
} }