mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

validation: reset BLOCK_FAILED_CHILD to BLOCK_FAILED_VALID when loading from disk

Browse Source 
- there maybe existing block indexes stored in disk with
  BLOCK_FAILED_CHILD
- since they don't exist anymore, clean up block index entries with
  BLOCK_FAILED_CHILD and reset it to BLOCK_FAILED_VALID.
This commit is contained in:
stratospher committed 2026-02-17 21:40:46 +05:30
1 parent 37bc207852
commit b5b2956bda
1 file changed
+8
Download Patch File Download Diff File Expand all files Collapse all files
src/node/blockstorage.cpp
+8
View File
@@ -487,10 +487,18 @@ bool BlockManager::LoadBlockIndex(const std::optional<uint256>& snapshot_blockha
pindex->m_chain_tx_count = pindex->nTx; pindex->m_chain_tx_count = pindex->nTx;
} }
} }
if (pindex->nStatus & BLOCK_FAILED_CHILD) {
// BLOCK_FAILED_CHILD is deprecated, but may still exist on disk. Replace it with BLOCK_FAILED_VALID.
pindex->nStatus = (pindex->nStatus & ~BLOCK_FAILED_CHILD) | BLOCK_FAILED_VALID;
m_dirty_blockindex.insert(pindex);
}
if (!(pindex->nStatus & BLOCK_FAILED_MASK) && pindex->pprev && (pindex->pprev->nStatus & BLOCK_FAILED_MASK)) { if (!(pindex->nStatus & BLOCK_FAILED_MASK) && pindex->pprev && (pindex->pprev->nStatus & BLOCK_FAILED_MASK)) {
// All descendants of invalid blocks are invalid too.
pindex->nStatus |= BLOCK_FAILED_VALID; pindex->nStatus |= BLOCK_FAILED_VALID;
m_dirty_blockindex.insert(pindex); m_dirty_blockindex.insert(pindex);
} }
if (pindex->pprev) { if (pindex->pprev) {
pindex->BuildSkip(); pindex->BuildSkip();
} }