mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

keypool: Remove superfluous topup from CWallet::GetNewChangeDestination

Browse Source 
This does not change behavior. This TopUp() is unnecessary as currently
m_spk_man calls TopUp further down the call stack inside
LegacyScriptPubKeyMan::ReserveKeyFromKeyPool (called by LegacyScriptPubKeyMan::GetReservedDestination)

By removing this here, we also prepare for future changes where CWallet
has multiple ScriptPubKeyMans instead of m_spk_man.
This commit is contained in:
Andrew Chow committed 2019-11-22 23:45:34 -05:00
1 parent 0b79caf658
commit bb2c8ce23c
1 file changed
-2
Download Patch File Download Diff File Expand all files Collapse all files
src/wallet/wallet.cpp
-2
View File
@@ -3122,8 +3122,6 @@ bool CWallet::GetNewChangeDestination(const OutputType type, CTxDestination& des
{ {
error.clear(); error.clear();
m_spk_man->TopUp();
ReserveDestination reservedest(this, type); ReserveDestination reservedest(this, type);
if (!reservedest.GetReservedDestination(dest, true)) { if (!reservedest.GetReservedDestination(dest, true)) {
error = "Error: Keypool ran out, please call keypoolrefill first"; error = "Error: Keypool ran out, please call keypoolrefill first";