Merge bitcoin/bitcoin#27114: p2p: Allow whitelisting manual connections
0a533613fbdocs: add release notes for #27114 (brunoerg)e6b8f19de9test: add coverage for whitelisting manual connections (brunoerg)c985eb854ctest: add option to speed up tx relay/mempool sync (brunoerg)66bc6e2d17Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections (Luke Dashjr)8e06be347cnet_processing: Move extra service flag into InitializeNode (Luke Dashjr)9133fd69a5net: Move `NetPermissionFlags::Implicit` verification to `AddWhitelistPermissionFlags` (Luke Dashjr)2863d7dddbnet: store `-whitelist{force}relay` values in `CConnman` (brunoerg) Pull request description: Revives #17167. It allows whitelisting manual connections. Fixes #9923 Since there are some PRs/issues around this topic, I'll list some motivations/comments for whitelisting outbound connections from them: - Speed-up tx relay/mempool sync for testing purposes (my personal motivation for this) - In #26970, theStack pointed out that we whitelist peers to speed up tx relay for fast mempool synchronization, however, since it applies only for inbound connections and considering the topology `node0 <--- node1 <---- node2 <--- ... <-- nodeN`, if a tx is submitted from any node other than node0, the mempool synchronization can take quite long. - https://github.com/bitcoin/bitcoin/pull/29058#issuecomment-1865155764 - "Before enabling -v2transport by default (which I'd image may happen after https://github.com/bitcoin/bitcoin/pull/24748) we could consider a way to force manual connections to be only-v1 or even only-v2 (disabling reconnect-with-v1). A possibility could be through a net permission flag, if https://github.com/bitcoin/bitcoin/pull/27114 makes it in." - https://github.com/bitcoin/bitcoin/pull/17167#issuecomment-1168606032 - "This would allow us to use https://github.com/bitcoin/bitcoin/pull/25355 when making outgoing connections to all nodes, except to whitelisted ones for which we would use our persistent I2P address." - Force-relay/mempool permissions for a node you intentionally connected to. ACKs for top commit: achow101: ACK0a533613fbsr-gi: re-ACK [0a53361](https://github.com/bitcoin/bitcoin/pull/27114/commits/0a533613fb44207053796fd01a9f4b523a3153d4) pinheadmz: ACK0a533613fbTree-SHA512: 97a79bb854110da04540897d2619eda409d829016aafdf1825ab5515334b0b42ef82f33cd41587af235b3af6ddcec3f2905ca038b5ab22e4c8a03d34f27aebe1
This commit is contained in:
41 files changed
+199
-108
No files matched your search
@@ -30,10 +30,11 @@ class WalletSendTest(BitcoinTestFramework):
|
||||
|
||||
def set_test_params(self):
|
||||
self.num_nodes = 2
|
||||
# whitelist all peers to speed up tx relay / mempool sync
|
||||
# whitelist peers to speed up tx relay / mempool sync
|
||||
self.noban_tx_relay = True
|
||||
self.extra_args = [
|
||||
["-whitelist=127.0.0.1","-walletrbf=1"],
|
||||
["-whitelist=127.0.0.1","-walletrbf=1"],
|
||||
["-walletrbf=1"],
|
||||
["-walletrbf=1"]
|
||||
]
|
||||
getcontext().prec = 8 # Satoshi precision for Decimal
|
||||
|
||||
|
||||
Reference in new issue
Block a user