Merge bitcoin/bitcoin#33247: build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings
2594d5a189build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings (Henry Romp) Pull request description: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings that are no longer needed after reordering the Guix build script to perform binary checks after installation. This PR also removes the unused CMake maintenance targets (`check-security` and `check-symbols`) and updates the Guix security checks to include binaries in the `libexec/` directory (added in PR #31679). ACKs for top commit: purpleKarrot: ACK2594d5a189hebasto: ACK2594d5a189. Tree-SHA512: ed451a298f5aae05c177b0033b092faaa7536caeaa3d84da9b8b611e2aa905e1dd337e57aef0efd69ce6ce6ac0cf77dc57adf175079b95bf53dd96d5d0c8118b
This commit is contained in:
5 files changed
+7
-55
No files matched your search
@@ -254,11 +254,6 @@ mkdir -p "$DISTSRC"
|
||||
# Build Bitcoin Core
|
||||
cmake --build build -j "$JOBS" ${V:+--verbose}
|
||||
|
||||
# Perform basic security checks on a series of executables.
|
||||
cmake --build build -j 1 --target check-security ${V:+--verbose}
|
||||
# Check that executables only contain allowed version symbols.
|
||||
cmake --build build -j 1 --target check-symbols ${V:+--verbose}
|
||||
|
||||
mkdir -p "$OUTDIR"
|
||||
|
||||
# Make the os-specific installers
|
||||
@@ -288,6 +283,13 @@ mkdir -p "$DISTSRC"
|
||||
;;
|
||||
esac
|
||||
|
||||
# Perform basic security checks on installed executables.
|
||||
echo "Checking binary security on installed executables..."
|
||||
python3 "${DISTSRC}/contrib/guix/security-check.py" "${INSTALLPATH}/bin/"* "${INSTALLPATH}/libexec/"*
|
||||
# Check that executables only contain allowed version symbols.
|
||||
echo "Running symbol and dynamic library checks on installed executables..."
|
||||
python3 "${DISTSRC}/contrib/guix/symbol-check.py" "${INSTALLPATH}/bin/"* "${INSTALLPATH}/libexec/"*
|
||||
|
||||
(
|
||||
cd installed
|
||||
|
||||
|
||||
Reference in new issue
Block a user