Merge bitcoin/bitcoin#34417: log: Print warning about privacy-sensitive log info unconditionally

fa9c92d7b6 log: Print warning about privacy-sensitive log info unconditionally (MarcoFalke)

Pull request description:

  There is a warning about logs containing privacy-sensitive information. However, it is only printed when at least one debug log category is enabled.

  This is confusing, because:

  * Setting (let's say) `-debug=reindex` enables this warning, but it is hard to see what sensitive logs could be contained in reindex debug logs.
  * Dropping `-debug=reindex` again disabled this warning, but the wallet continues to log txids (and other sensitive stuff) at info level.

  So instead of implying the wrong thing, it would be better to remove this log line (because it should be common sense), or log it unconditionally.

ACKs for top commit:
  l0rinc:
    ACK fa9c92d7b6
  sedited:
    ACK fa9c92d7b6

Tree-SHA512: 42f71b030e7722203f225f04e979143e829dae3556f64e322a791361a3b9c16150d53bb7bb9a99839c975d9052115770b9473138acc58baeee457253526fd892
This commit is contained in:
merge-script committed 2026-01-28 18:50:16 +01:00
commit d3e8c459e7
1 file changed
+1 -3
+1 -3
View File
@@ -99,9 +99,7 @@ util::Result<void> SetLoggingCategories(const ArgsManager& args)
} }
} }
if (LogInstance().GetCategoryMask() != BCLog::NONE) { LogInfo("Log output may contain privacy-sensitive information. Be cautious when sharing logs.");
LogInfo("Debug logging is enabled (-debug). Additional log output may contain privacy-sensitive information. Be cautious when sharing logs.");
}
return {}; return {};
} }