kernel: SanityChecks: Return an error struct

This reduces libbitcoinkernel's coupling with ui_interface and
translation.
This commit is contained in:
Carl Dong committed 2022-06-02 12:22:46 -04:00
1 parent 265d6393bf
commit d87784ac87
4 files changed
+31 -12

No files matched your search

+6 -9
View File
@@ -5,29 +5,26 @@
#include <kernel/checks.h>
#include <key.h>
#include <node/ui_interface.h>
#include <random.h>
#include <util/time.h>
#include <util/translation.h>
#include <memory>
namespace kernel {
bool SanityChecks(const Context&) {
std::optional<SanityCheckError> SanityChecks(const Context&)
{
if (!ECC_InitSanityCheck()) {
return InitError(Untranslated("Elliptic curve cryptography sanity check failure. Aborting."));
return SanityCheckError::ERROR_ECC;
}
if (!Random_SanityCheck()) {
return InitError(Untranslated("OS cryptographic RNG sanity check failure. Aborting."));
return SanityCheckError::ERROR_RANDOM;
}
if (!ChronoSanityCheck()) {
return InitError(Untranslated("Clock epoch mismatch. Aborting."));
return SanityCheckError::ERROR_CHRONO;
}
return true;
return std::nullopt;
}
}
+9 -1
View File
@@ -5,14 +5,22 @@
#ifndef BITCOIN_KERNEL_CHECKS_H
#define BITCOIN_KERNEL_CHECKS_H
#include <optional>
namespace kernel {
struct Context;
enum class SanityCheckError {
ERROR_ECC,
ERROR_RANDOM,
ERROR_CHRONO,
};
/**
* Ensure a usable environment with all necessary library support.
*/
bool SanityChecks(const Context&);
std::optional<SanityCheckError> SanityChecks(const Context&);
}