addrman, refactor: improve stochastic test in AddSingle
This commit changes this algo to be O(1) instead of O(n) by using `<<`.
This commit is contained in:
1 parent
c9f288244b
commit
e064487ca2
1 file changed
+4
-5
+4
-5
@@ -585,11 +585,10 @@ bool AddrManImpl::AddSingle(const CAddress& addr, const CNetAddr& source, std::c
|
|||||||
return false;
|
return false;
|
||||||
|
|
||||||
// stochastic test: previous nRefCount == N: 2^N times harder to increase it
|
// stochastic test: previous nRefCount == N: 2^N times harder to increase it
|
||||||
int nFactor = 1;
|
if (pinfo->nRefCount > 0) {
|
||||||
for (int n = 0; n < pinfo->nRefCount; n++)
|
const int nFactor{1 << pinfo->nRefCount};
|
||||||
nFactor *= 2;
|
if (insecure_rand.randrange(nFactor) != 0) return false;
|
||||||
if (nFactor > 1 && (insecure_rand.randrange(nFactor) != 0))
|
}
|
||||||
return false;
|
|
||||||
} else {
|
} else {
|
||||||
pinfo = Create(addr, source, &nId);
|
pinfo = Create(addr, source, &nId);
|
||||||
pinfo->nTime = std::max(NodeSeconds{0s}, pinfo->nTime - time_penalty);
|
pinfo->nTime = std::max(NodeSeconds{0s}, pinfo->nTime - time_penalty);
|
||||||
|
|||||||
Reference in new issue
Block a user