doc: add explanations for assert in index and magic numbers in test
These were suggested in review of #23365 Co-authored-by: John Newbery <john@johnnewbery.com>
This commit is contained in:
1 parent
aaaceb7fb1
commit
e4a8d561ed
2 files changed
+4
No files matched your search
@@ -96,6 +96,8 @@ bool BaseIndex::Init()
|
|||||||
prune_violation = false;
|
prune_violation = false;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
// block->pprev must exist at this point, since block_to_test is part of the chain
|
||||||
|
// and thus must be encountered when going backwards from the tip
|
||||||
assert(block->pprev);
|
assert(block->pprev);
|
||||||
block = block->pprev;
|
block = block->pprev;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -29,6 +29,8 @@ class FeatureBlockfilterindexPruneTest(BitcoinTestFramework):
|
|||||||
|
|
||||||
self.log.info("prune some blocks")
|
self.log.info("prune some blocks")
|
||||||
pruneheight = self.nodes[0].pruneblockchain(400)
|
pruneheight = self.nodes[0].pruneblockchain(400)
|
||||||
|
# the prune heights used here and below are magic numbers that are determined by the
|
||||||
|
# thresholds at which block files wrap, so they depend on disk serialization and default block file size.
|
||||||
assert_equal(pruneheight, 248)
|
assert_equal(pruneheight, 248)
|
||||||
|
|
||||||
self.log.info("check if we can access the tips blockfilter when we have pruned some blocks")
|
self.log.info("check if we can access the tips blockfilter when we have pruned some blocks")
|
||||||
|
|||||||
Reference in new issue
Block a user