mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sign: Remove duplicate sigversion check

Browse Source 
Also improves documentation in the SignMuSig2 function.
This commit is contained in:
Fabian Jahr committed 2025-11-24 18:48:43 +01:00
1 parent 0f7f0692ca
commit e755614be5
1 file changed
+1 -3
Download Patch File Download Diff File Expand all files Collapse all files
src/script/sign.cpp
+1 -3
View File
@@ -87,8 +87,6 @@ std::optional<uint256> MutableTransactionSignatureCreator::ComputeSchnorrSignatu
bool MutableTransactionSignatureCreator::CreateSchnorrSig(const SigningProvider& provider, std::vector<unsigned char>& sig, const XOnlyPubKey& pubkey, const uint256* leaf_hash, const uint256* merkle_root, SigVersion sigversion) const bool MutableTransactionSignatureCreator::CreateSchnorrSig(const SigningProvider& provider, std::vector<unsigned char>& sig, const XOnlyPubKey& pubkey, const uint256* leaf_hash, const uint256* merkle_root, SigVersion sigversion) const
{ {
assert(sigversion == SigVersion::TAPROOT || sigversion == SigVersion::TAPSCRIPT);
CKey key; CKey key;
if (!provider.GetKeyByXOnly(pubkey, key)) return false; if (!provider.GetKeyByXOnly(pubkey, key)) return false;
@@ -342,7 +340,7 @@ static bool SignMuSig2(const BaseSignatureCreator& creator, SignatureData& sigda
sigdata.musig2_partial_sigs[pub_key_leaf_hash].emplace(part_pk, partial_sig); sigdata.musig2_partial_sigs[pub_key_leaf_hash].emplace(part_pk, partial_sig);
} }
} }
// If there are any partial signatures, exit early // If there are any partial signatures, continue with next aggregate pubkey
auto partial_sigs_it = sigdata.musig2_partial_sigs.find(pub_key_leaf_hash); auto partial_sigs_it = sigdata.musig2_partial_sigs.find(pub_key_leaf_hash);
if (partial_sigs_it != sigdata.musig2_partial_sigs.end() && !partial_sigs_it->second.empty()) { if (partial_sigs_it != sigdata.musig2_partial_sigs.end() && !partial_sigs_it->second.empty()) {
continue; continue;