mirror/bitcoin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove atomic for m_last_getheaders_timestamp

Browse Source 
This variable is only used in a single thread, so no atomic or mutex is
necessary to guard it.
This commit is contained in:
Suhas Daftuar committed 2022-07-12 13:38:14 -04:00
1 parent aeab1b42e6
commit e939cf2b76
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
src/net_processing.cpp
+3 -3
View File
@@ -358,7 +358,7 @@ struct Peer {
std::deque<CInv> m_getdata_requests GUARDED_BY(m_getdata_requests_mutex); std::deque<CInv> m_getdata_requests GUARDED_BY(m_getdata_requests_mutex);
/** Time of the last getheaders message to this peer */ /** Time of the last getheaders message to this peer */
std::atomic<NodeClock::time_point> m_last_getheaders_timestamp{NodeSeconds{}}; NodeClock::time_point m_last_getheaders_timestamp{};
Peer(NodeId id) Peer(NodeId id)
: m_id{id} : m_id{id}
@@ -2276,7 +2276,7 @@ bool PeerManagerImpl::MaybeSendGetHeaders(CNode& pfrom, const CBlockLocator& loc
// Only allow a new getheaders message to go out if we don't have a recent // Only allow a new getheaders message to go out if we don't have a recent
// one already in-flight // one already in-flight
if (current_time - peer.m_last_getheaders_timestamp.load() > HEADERS_RESPONSE_TIME) { if (current_time - peer.m_last_getheaders_timestamp > HEADERS_RESPONSE_TIME) {
m_connman.PushMessage(&pfrom, msgMaker.Make(NetMsgType::GETHEADERS, locator, uint256())); m_connman.PushMessage(&pfrom, msgMaker.Make(NetMsgType::GETHEADERS, locator, uint256()));
peer.m_last_getheaders_timestamp = current_time; peer.m_last_getheaders_timestamp = current_time;
return true; return true;
@@ -3974,7 +3974,7 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
// Assume that this is in response to any outstanding getheaders // Assume that this is in response to any outstanding getheaders
// request we may have sent, and clear out the time of our last request // request we may have sent, and clear out the time of our last request
peer->m_last_getheaders_timestamp.store(NodeSeconds{}); peer->m_last_getheaders_timestamp = {};
std::vector<CBlockHeader> headers; std::vector<CBlockHeader> headers;