From fad7f423249c161cad20a754653f9477e2b98339 Mon Sep 17 00:00:00 2001 From: Fabian Jahr Date: Sat, 2 Mar 2024 21:26:48 +0100 Subject: [PATCH 1/3] lint: Clarify lint runner rust dependency --- test/lint/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/lint/README.md b/test/lint/README.md index 9cb61b484c..83264de06e 100644 --- a/test/lint/README.md +++ b/test/lint/README.md @@ -16,7 +16,11 @@ result is cached and it prevents issues when the image changes. test runner =========== -To run all the lint checks in the test runner outside the docker, use: +To run all the lint checks in the test runner outside the docker you first need +to install the rust toolchain using your package manager of choice or +[rustup](https://www.rust-lang.org/tools/install). + +Then you can use: ```sh ( cd ./test/lint/test_runner/ && cargo fmt && cargo clippy && RUST_BACKTRACE=1 cargo run ) From cfa057b86d735942adbeb7347a51b6f0c32901f7 Mon Sep 17 00:00:00 2001 From: Fabian Jahr Date: Sat, 2 Mar 2024 21:28:41 +0100 Subject: [PATCH 2/3] lint: Add lint runner build dir to gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c77303f50e..3fe36aba89 100644 --- a/.gitignore +++ b/.gitignore @@ -130,6 +130,7 @@ win32-build test/config.ini test/cache/* test/.mypy_cache/ +test/lint/test_runner/target/ !src/leveldb*/Makefile From 742d2b93473a856786e32c5e35e3b6ce2a95000f Mon Sep 17 00:00:00 2001 From: Fabian Jahr Date: Sat, 2 Mar 2024 21:39:31 +0100 Subject: [PATCH 3/3] lint: Add lint runner build dir and lint pycache to clean task --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index eec498dc0e..5ea690dec8 100644 --- a/Makefile.am +++ b/Makefile.am @@ -338,7 +338,7 @@ clean-docs: clean-local: clean-docs rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ fuzz.coverage/ test/tmp/ cache/ $(OSX_APP) rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__ - rm -rf osx_volname dist/ + rm -rf osx_volname dist/ test/lint/test_runner/target/ test/lint/__pycache__ test-security-check: if TARGET_DARWIN