Change bug status in 1992/gson
An additional look shows that the gets(3) call is for the dictionary file. It is highly unlikely (though not impossible) that the dictionary file would ever have a line 256 in length and this as well as because it was documented is why I changed the buffer size back to the original. The bug status does still suggest it would be nice if fgets(3) could be used but it also lists the bugs and limitations the author stated in the first place which actually does refer to the 256 limit. I moved the notice to those who want a challenge up a bit in the README.md file to be right above obfuscatory notes rather than before those notes get into the details.
This commit is contained in:
1 parent
7fd2ccf683
commit
03b9d7e27e
7 files changed
+223
-213
No files matched your search
@@ -1932,12 +1932,6 @@ for [ShellCheck](https://www.shellcheck.net)
|
||||
because the author deliberately obfuscated it so **PLEASE *DO NOT* FIX THIS OR
|
||||
MODERNISE IT**.
|
||||
|
||||
Cody also changed the buffer size in such a way that `gets(3)` should be safe
|
||||
(well, theoretically) as it comes from the command line (though it can also read input
|
||||
from `stdin` after starting the program). Ideally `fgets(3)` would be used but this
|
||||
is a more problematic. See [1992/gson in bugs.html](bugs.html#1992_gson) for more
|
||||
details if you're interested in trying to understand it (or fix?).
|
||||
|
||||
|
||||
<div id="1992_imc">
|
||||
## Winning entry: [1992/imc](1992/imc/index.html)
|
||||
|
||||
Reference in new issue
Block a user