Merge pull request #1118 from xexyl/thanks-updates

This commit is contained in:
Landon Curt Noll authored and GitHub committed 2023-10-19 11:34:51 -07:00
commit 07f47f3e1b
1 file changed
+16 -15
+16 -15
View File
@@ -497,9 +497,7 @@ you know how?
Cody fixed an infinite loop where the program would print the same thing over Cody fixed an infinite loop where the program would print the same thing over
and over again, flooding the screen. The problem is that there was a `for` loop and over again, flooding the screen. The problem is that there was a `for` loop
that by necessity had to not have an increment stage but only in the `if` path that by necessity had to not have an increment stage but only in the `if` path
(in the loop itself) did the pointer get updated. Looking at the code it might (in the loop itself) did the pointer get updated.
be that it can work just as well by adding the increment in the loop itself but
this was not done.
Cody also provided an [alternate version](1989/ovdluhe/ovdluhe.alt.c) based on the Cody also provided an [alternate version](1989/ovdluhe/ovdluhe.alt.c) based on the
author's remarks. See the README.md for details. The fix described above was author's remarks. See the README.md for details. The fix described above was
@@ -514,13 +512,14 @@ he was using lldb and saw that the type of a pointer was too `long` :-)
## [1989/robison](1989/robison/robison.c) ([README.md](1989/robison/README.md])) ## [1989/robison](1989/robison/robison.c) ([README.md](1989/robison/README.md]))
cd 1989/robison ; make orig_prog_diff
Yusuke Endoh fixed this to compile under modern systems. To see the changes Yusuke Endoh fixed this to compile under modern systems. To see the changes
made, try: made, try:
```sh ```sh
git diff d2a42f42e8f477f29e9d5ed09ce2bb349eaf7397..9d63c37f490da333fbb1ed7db9571902570d4bad 1989/robison/robison.c cd 1989/robison ; make orig_prog_diff
``` ```
(It adds the C token pasting operator `##` instead of `/**/`.) (It adds the C token pasting operator `##` instead of `/**/`.)
@@ -528,19 +527,21 @@ git diff d2a42f42e8f477f29e9d5ed09ce2bb349eaf7397..9d63c37f490da333fbb1ed7db9571
## [1989/tromp](1989/tromp/tromp.c) ([README.md](1989/tromp/README.md])) ## [1989/tromp](1989/tromp/tromp.c) ([README.md](1989/tromp/README.md]))
We used a patch from Yusuke to get this to compile under gcc. Cody and Yusuke fixed this entry: Yusuke fixed this to compile with gcc and Cody
fixed it for clang and made some other fixes as well.
Cody fixed this to work with clang by further changing the variable `a` to be To get it to work with clang the variable `a` had to not be the third argument
not the third argument to `main()` but instead be a variable declared in to `main()` but instead be a variable in `main()`.
`main()`.
Cody also bug fixed it so that the high score file would work (it was not even Cody also fixed a segfault and made it so the that the high score file would
being created) and after this making sure the terminal stayed sane (the letter work (it was not even being created but it was supposed to be).
'`u`' could not be typed and echo was disabled outright after the segfault fix /
high score file was reinstated). Although we appreciate the help here, he Another problem Cody fixed was that the terminal was left in an insane state where you
cynically noted that he had to have an IOCCC could not type '`u`' and echo was completely disabled.
[Tetris](https://en.wikipedia.org/wiki/Tetris) working (this of course was not
his only reason :-) ) Although we appreciate the help here, he cynically noted that he had to have an
IOCCC [Tetris](https://en.wikipedia.org/wiki/Tetris) working (this of course was
not his only reason :-) )
## [1989/westley](1989/westley/westley.c) ([README.md](1989/westley/README.md])) ## [1989/westley](1989/westley/westley.c) ([README.md](1989/westley/README.md]))