From 245beb7759ae72e725cdd6f442f5bf9c3d2f8f53 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Sat, 1 Jul 2023 08:03:23 -0700 Subject: [PATCH] Mark infinite loop a feature in 1990/westley It seems more like a feature than a bug if one enters input that is not a number > 0. This was considered a bug in the bugs.md file and noted in the README.md file but it seems like it's not something that should be fixed but merely noted as a feature. --- 1990/westley/README.md | 5 +++-- bugs.md | 14 +++++--------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/1990/westley/README.md b/1990/westley/README.md index a1beb73b8..0b80ac8b0 100644 --- a/1990/westley/README.md +++ b/1990/westley/README.md @@ -21,11 +21,12 @@ make all ./westley number ``` -NOTE: this program will enter an infinite loop if input is not a number > 0. ### INABIAF - it's not a bug it's a feature :-) -NOTE: this entry will very likely crash or do something else without an arg. +This entry will very likely crash or do something else without an arg. + +This program will enter an infinite loop if input is not a number > 0. ## Try: diff --git a/bugs.md b/bugs.md index a656b9105..d0dd88e0d 100644 --- a/bugs.md +++ b/bugs.md @@ -252,9 +252,9 @@ fixed he did it by adding a function called `pain()`. :-) clang** despite the fact it might appear to be gcc: no symlink and both gcc and clang exist but the gcc is clang which you'll see if you run `gcc --version`. -A tip and some fix methods from Cody: in the older days args to main() not given -a type were implicit ints but when they're required to be char ** this can cause -a problem. In some cases Cody was able to use a char * inside main() (see +A tip and some fix methods from Cody: in the older days args not given a type +were implicit ints but when they're required to be char ** this can cause a +problem. In some cases Cody was able to use a char * inside main() (see [1989/tromp/tromp.c](1989/tromp/tromp.c) and [1986/holloway/holloway.c](1986/holloway) for two examples though done slightly differently). In other cases he was able to dereference the pointers to be used @@ -612,13 +612,9 @@ where this occurred was fixed but this one should not be fixed. Thank you. ## [1990/westley](1990/westley/westley.c) ([README.md](1990/westley/README.md)) ## STATUS: INABIAF - please **DO NOT** fix -This entry will crash without an arg. At this time this is not considered worth -fixing so it should not be fixed. +This entry will very likely crash or do something strange without an arg. -## STATUS: known bug - please help us fix - -However any input not a number > 0 will make the program enter an infinite loop. -This will be fixed in time but it's noted here for now. +This entry will also enter an infinite loop if input is not a number > 0. # 1991