From 2941c57bbf02f50860d2ca1cc5277a8fe804b42f Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Tue, 18 Jul 2023 09:58:13 -0700 Subject: [PATCH] Change bug status of 1994/ldb The issue is that when fixing the interspersed output of the annoying warning in macOS about using gets() an extra newline is printed out. This is because fgets() stores the newline and gets() does not. But since the warning kind of ruins the entry and a blank line is better than the warning it seems like a worthy compromise. That was already agreed upon but as it's a one liner and it's already quite long it might be better to just not worry about it as although kind of annoying a blank line isn't a big deal. --- bugs.md | 10 +++++----- thanks-for-fixes.md | 15 +++++++++------ 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/bugs.md b/bugs.md index df8dc8c1c..6b62c03fc 100644 --- a/bugs.md +++ b/bugs.md @@ -751,7 +751,7 @@ If not enough args are specified this program will likely crash or do something else. This should NOT be fixed. ## [1994/ldb](1994/ldb/ldb.c) ([README.md](1994/ldb/README.md)) -## STATUS: known bug - please help us fix +## STATUS: INABIAF - please **DO NOT** fix [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) fixed this to compile with modern systems (see the [thanks-for-fixes.md](thanks-for-fixes.md) file for @@ -761,10 +761,10 @@ also overflow long lines. Cody changed it to `fgets()` to prevent the display problem but this introduces another problem namely that newlines can be printed if the line length < 231. -This seems like a worthy compromise but it would be ideal for it to never print -a newline unless that's the line itself (a blank line). - -Cody will be looking at this later on. +This seems like a worthy compromise to not have messed up output and although it +would be ideal for it to never print a newline unless that's the line itself it +might be tampering too much with the entry as it's not a real problem and as a +one liner it's already quite long. ## [1994/schnitzi](1994/schnitzi/schnitzi.c) ([README.md])(1994/schnitzi/README.md)) diff --git a/thanks-for-fixes.md b/thanks-for-fixes.md index e4b60bf58..a0cb74553 100644 --- a/thanks-for-fixes.md +++ b/thanks-for-fixes.md @@ -13,9 +13,10 @@ Ferguson](/winners.html#Cody_Boone_Ferguson) who is responsible for many of the improvements including many, many complicated bug fixes like [2001/anonymous](2001/anonymous/anonymous.c), making entries not require `-traditional-cpp`, fixing entries to compile with clang, providing alternate -code where useful or necessary, typo and consistency fixes. Thank you **very -much** for your extensive efforts in helping improve the IOCCC presentation of -past IOCCC winners and making many work with modern systems! +code where useful or necessary, fixing where possible dead links and otherwise +removing them, typo and consistency fixes. Thank you **very much** for your +extensive efforts in helping improve the IOCCC presentation of past IOCCC +winners and making many work with modern systems! [Yusuke Endoh](/winners.html#Yusuke_Endoh) supplied a number of important bug fixes to a number of past IOCCC winners. Some of @@ -625,9 +626,11 @@ Cody also changed the entry to use `fgets()` instead of `gets()` to make it safe for lines greater than 231 in length and to prevent a warning at linking or at runtime, the latter of which can be interspersed with output of the program. Note that this now prints a newline after the output but this seems like a -worthy compromise for making the output incorrect in macOS and at the same time -it's safer (fixing it to not have the extra newline is more problematic than -it's worth and in macOS another line of output would be shown anyway). +worthy compromise for preventing the interspersed output in macOS and at the +same time it's safer (fixing it to not have the extra newline is more +problematic than it's worth and in macOS another line of output would be shown +without the change anyway and the difference is that now it's just a blank line +rather than an annoying warning). A subtlety about this fix: if a line is greater than 231 in length if the program chooses that line it might print the first 231 characters or it might