From 2b0864e4dfc410ed0f38b82e564ec12370d7cfae Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 7 Apr 2023 11:15:33 -0700 Subject: [PATCH 1/5] Reword thank you in 1996/westley --- 1996/westley/README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/1996/westley/README.md b/1996/westley/README.md index 1c6c29949..c097e0715 100644 --- a/1996/westley/README.md +++ b/1996/westley/README.md @@ -13,13 +13,13 @@ [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) fixed a segfault in -this entry as well as it displaying environmental variables if argc == 1. -Although the scripts showed correct output these also segfaulted but with the -fix they no longer do. Now if argc < 5 (argv[4] is referenced) it will not do -anything and it will not segfault either (this was caused by the body of the -for() loop which is now empty (it doesn't appear to be needed at all). Note that -this does make some of the author's explanations / portability notes no longer -valid but we have kept them there for the interested. Thank you Cody for your assistance! +this entry as well as it displaying environmental variables. Although the +scripts showed correct output these also segfaulted but with the fix they no +longer do. Now if argc < 5 (argv[4] is referenced) it will not do anything and +it will not segfault either (this was caused by the body of the for() loop which +is now empty (it doesn't appear to be needed at all). Note that this does make +some of the author's explanations / portability notes no longer valid but we +have kept them there for the interested. Thank you Cody for your assistance! ## To run: From 94bdc82d320075b25dd96f7782fa5795d7303a2e Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 7 Apr 2023 11:16:24 -0700 Subject: [PATCH 2/5] Move author info to first column in 1998/chaos --- 1998/chaos/README.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/1998/chaos/README.md b/1998/chaos/README.md index c3d690898..bd3a87975 100644 --- a/1998/chaos/README.md +++ b/1998/chaos/README.md @@ -1,11 +1,10 @@ # Best Object Orientation: - Alan De Smet - 8531 Greenway Blvd. #206 - Middleton, WI 53562 - USA - - http://www.upl.cs.wisc.edu/~chaos/ +Alan De Smet +8531 Greenway Blvd. #206 +Middleton, WI 53562 +USA + ## To build: @@ -13,7 +12,7 @@ make chaos NOTE: Some systems do not implement `halfdelay()` in their `libcurses`. -You might try compiling with -lncurses of you have that library. +You might try compiling with -lncurses if you have that library. Or you can build this entry without the `halfdelay()` call by: make chaos_nohalf From be7815388c8ebccaf0b88dd299cef5aec33b1af9 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 7 Apr 2023 11:17:13 -0700 Subject: [PATCH 3/5] Minor update to 1998/schweikh1/README.md Point out that skipping a file that cannot be opened lets the entry work right. I no longer remember the exact details. --- 1998/schweikh1/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/1998/schweikh1/README.md b/1998/schweikh1/README.md index d724fad52..001af39ba 100644 --- a/1998/schweikh1/README.md +++ b/1998/schweikh1/README.md @@ -14,7 +14,8 @@ [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) fixed this for modern systems (it did not work at all). He also made it so that if a file fails to -open it does not return but rather skips the reading of the file. +open it does not return but rather skips the reading of the file. Doing this +lets the entry work right. What was wrong? The call to `freopen()` was incorrect with the second arg (the mode) being instead `5+__FILE__`. It now is `"r"`. There was also a call to From 727f1e1fe1857580b6df5318021675584127421c Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 7 Apr 2023 11:19:36 -0700 Subject: [PATCH 4/5] Reword note about fgets() in 2000/anderson --- 2000/anderson/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/2000/anderson/README.md b/2000/anderson/README.md index 18fd9f7bd..2d5e87b3b 100644 --- a/2000/anderson/README.md +++ b/2000/anderson/README.md @@ -13,7 +13,8 @@ make ``` [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) changed this entry to -use `fgets()` instead of `gets()` to make it safer. Thank you Cody! +use `fgets()` instead of `gets()` to make it safer and to prevent warnings from +showing up at linking or runtime. Thank you Cody! For the original source [anderson.alt.c](anderson.alt.c) see below. From 3e29d777ceb2a9b0a2c8f9609613acaf298d5c3d Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 7 Apr 2023 11:20:36 -0700 Subject: [PATCH 5/5] Reword note about fix in 2000/natori I had said the fix I did made it works with modern compilers but fixed for modern compilers is more precise though it might be a subtle difference. --- 2000/natori/README.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/2000/natori/README.md b/2000/natori/README.md index 659cdec50..a5eebe35d 100644 --- a/2000/natori/README.md +++ b/2000/natori/README.md @@ -12,10 +12,9 @@ Japan make ``` -[Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) fixed this so that it -works with modern compilers. Depending on the compiler it would either segfault -when run or not compile at all (gcc and clang respectively). Thank you Cody for -your assistance! +[Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) fixed this for modern +compilers. Depending on the compiler it would either segfault when run or not +compile at all (gcc and clang respectively). Thank you Cody for your assistance! ## To run: