Add 1992/gson/try.sh, add note about optimiser
The optimiser must be disabled due to it otherwise crashing in macOS in some invocations. This has been added to the Makefile, the use of -O0 is forced and a note has been added to the README.md file. The bugs.md file has been updated on details of how it uses gets() and that text has been removed from the thanks file. Minor format fixes in README.md. The script added makes use of the author's script (that I added as mkdict.sh for easier use) after first trying to find a dictionary file. But one can override the dictionary file with the DICT environmental variable. This entry should now truly be done.
This commit is contained in:
1 parent
fed6b32f0a
commit
54c5271117
5 files changed
+158
-20
No files matched your search
@@ -893,7 +893,18 @@ problem of `gets()` being used in a more complex way.
|
||||
|
||||
It would be ideal if it were to use `fgets()` though. This will probably be
|
||||
looked at later but you're welcome to try and fix this too! A tip on how
|
||||
`gets()` is being used is in the [FAQ](/faq.md#gets) file.
|
||||
`gets()` is being used from Cody:
|
||||
|
||||
Previously it had a buffer size of 256 which could easily overflow. In this
|
||||
entry `gets(3)` is used in a more complicated way: first `m` is set to `*++p` in
|
||||
a for loop where `p` is argv. Later `m` is set to point to `h` which was of size
|
||||
256. `gets(3)` is called as `m = gets(m)`) but trying to change it to use
|
||||
`fgets(3)` proved more a problem. Since the input must come from the command
|
||||
line Cody changed the buffer size to `ARG_MAX+1` which should be enough (again
|
||||
theoretically) especially since the command expects redirecting a dictionary
|
||||
file as part of the command line. This also makes it possible for longer strings
|
||||
to be read (in case the `gets(3)` was not used in a loop).
|
||||
|
||||
|
||||
|
||||
## 1992 kivinen
|
||||
|
||||
Reference in new issue
Block a user