From 5cbf43230ccfa339de214d9e36d0fc10cfa59abb Mon Sep 17 00:00:00 2001
From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com>
Date: Mon, 29 Jan 2024 02:30:57 -0800
Subject: [PATCH] Fix 2013/endoh3 for shellcheck

Even though the author used 'cat file | ...' use the form './endoh3 <
file | ...' rather than have to disable the shellcheck warning about
useless cat. In some cases using it does simplify the command but not
much in this case (though I still say there's no such thing as a useless
cat: besides offering endless joy and wonder how else would we EVER know
that the Earth is not flat if we didn't have cats to push everything off
flat surfaces? :-) .. I mean besides lots of science to back it up, that
is :-) ).
---
 2013/endoh3/try.sh | 33 ++++++---------------------------
 1 file changed, 6 insertions(+), 27 deletions(-)

diff --git a/2013/endoh3/try.sh b/2013/endoh3/try.sh
index 02606cd4c..39586e6b2 100755
--- a/2013/endoh3/try.sh
+++ b/2013/endoh3/try.sh
@@ -32,43 +32,22 @@ endoh3()
     fi
     if [[ -f "$1" && -r "$1" ]]; then
 	if [[ -n "$SOX" ]]; then
-	    echo "$ cat $1 | ./endoh3 | $SOX -q -traw -r8000 -b8 -e unsigned-integer - -tcoreaudio" 1>&2
+	    echo "$ ./endoh3 < $1 | $SOX -q -traw -r8000 -b8 -e unsigned-integer - -tcoreaudio" 1>&2
 	    read -r -n 1 -p "Press any key to continue: "
 	    echo 1>&2
-	    # The author suggested the form below and it simplifies the command
-	    # as well so we disable the supposed useless cat (there are no
-	    # useless cats).
-	    #
-	    # SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
-	    # https://www.shellcheck.net/wiki/SC2002
-	    # shellcheck disable=SC2002
-	    cat "$1" | ./endoh3 | "$SOX" -q -traw -r8000 -b8 -e unsigned-integer - -tcoreaudio
+	    ./endoh3 < "$1" | "$SOX" -q -traw -r8000 -b8 -e unsigned-integer - -tcoreaudio
 	    echo 1>&2
 	elif [[ -n "$PADSP" ]]; then
-	    echo "$ cat $1 | ./endoh3 | $PADSP tee /dev/dsp > /dev/null" 1>&2
+	    echo "$ ./endoh3 < $1 | $PADSP tee /dev/dsp > /dev/null" 1>&2
 	    read -r -n 1 -p "Press any key to continue: "
 	    echo 1>&2
-	    # The author suggested the form below and it simplifies the command
-	    # as well so we disable the supposed useless cat (there are no
-	    # useless cats).
-	    #
-	    # SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
-	    # https://www.shellcheck.net/wiki/SC2002
-	    # shellcheck disable=SC2002
-	    cat "$1" | ./endoh3 | "$PADSP" tee /dev/dsp > /dev/null
+	    ./endoh3 < "$1" | "$PADSP" tee /dev/dsp > /dev/null
 	    echo 1>&2
 	elif [[ -n "$RUBY" ]]; then
-	    echo "$ cat $1 | ./endoh3 | $RUBY wavify.rb > $1.wav" 1>&2
+	    echo "$ ./endoh3 < $1 | $RUBY wavify.rb > $1.wav" 1>&2
 	    read -r -n 1 -p "Press any key to continue: "
 	    echo 1>&2
-	    # The author suggested the form below and it simplifies the command
-	    # as well so we disable the supposed useless cat (there are no
-	    # useless cats).
-	    #
-	    # SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
-	    # https://www.shellcheck.net/wiki/SC2002
-	    # shellcheck disable=SC2002
-	    cat "$1" | ./endoh3 | "$RUBY" wavify.rb > "$1".wav
+	    ./endoh3 < "$1" | "$RUBY" wavify.rb > "$1".wav
 	    echo "Now try playing $1.wav in a program that plays WAV files." 1>&2
 	    echo 1>&2
 	else