From 70cee412ac92e915b13a098c70b5f89e6b9fd9b3 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Tue, 17 Oct 2023 10:24:31 -0700 Subject: [PATCH] Fix 1986/pawka/Makefile The flag -Wno-strict-prototypes was put in the CDEFINE variable, suggesting that it might need a -D flag when it of course does not. This is not strictly an error but it's also not strictly correct so I strictly decided to make it correct. At the same time I added to CSILENCE -Wno-implicit-int, a warning that has shown up in macOS recently, very possibly with macOS Sonoma, and so might have to be added to many Makefiles. --- 1986/pawka/Makefile | 5 +++-- thanks-for-fixes.md | 6 ++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/1986/pawka/Makefile b/1986/pawka/Makefile index d182f0e99..0b3fa1adb 100644 --- a/1986/pawka/Makefile +++ b/1986/pawka/Makefile @@ -38,7 +38,8 @@ include ../../var.mk # Common C compiler warnings to silence # -CSILENCE= -Wno-non-literal-null-conversion -Wno-unused-value +CSILENCE= -Wno-non-literal-null-conversion -Wno-unused-value -Wno-strict-prototypes \ + -Wno-implicit-int # Common C compiler warning flags # @@ -57,7 +58,7 @@ ARCH= # Defines that are needed to compile # -CDEFINE= -Wno-strict-prototypes +CDEFINE= # Include files that are needed to compile # diff --git a/thanks-for-fixes.md b/thanks-for-fixes.md index d18f6ea8f..1743098b2 100644 --- a/thanks-for-fixes.md +++ b/thanks-for-fixes.md @@ -247,6 +247,12 @@ and the third arg was an `int`. We encourage you to read the README.md file to see how odd this problem was and what Cody did to fix it! +## [1986/pawka](1986/pawka/pawka.c) ([README.md](1986/pawka/README.md)) + +Cody noticed and fixed a funny mistake in the Makefile where a +`-Wno-strict-prototypes` was in the wrong location, suggesting that there is a +`-D` needed to compile the entry. + ## [1986/wall](1986/wall/wall.c) ([README.md](1986/wall/README.md]))