From 775e159959945eeff0b96b8867f9eb4277e0cb03 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 6 Oct 2023 03:30:35 -0700 Subject: [PATCH] Fix links in thanks-for-fixes.md wrt winners.html Since linking to html files on GitHub does not render the html I have changed the winners.html to be https://www.ioccc.org/winners.html instead. In the process I have discovered that several README.md files still include '/winners.html' and these include some that have both Yusuke and me. Some of the names are supposed to stay there as they're mentioned by the author but some are not. These will be fixed in time: I have other modifications including to some README.md files and I don't want to accidentally commit the wrong files as some have changes that are not necessarily finished. Since it's the same kind of change it feels like a single pull request would be fitting (and easier) but since all the README.md files will have to be checked again (some once, some twice and that should be it) I will make these fixes (for those that need to be fixed .. for instance I can think of at least three where I was mentioned by another author so those should NOT be removed but the link should be changed!) then. I have updated the todo.md file as well to note the above as before I can say everything is done with the current issues related to consistency and typos the file must be checked and everything ticked off (or deleted) as the tasks are done. --- thanks-for-fixes.md | 78 +++++++++++++++++++++++++-------------------- todo.md | 30 ++++++++++------- 2 files changed, 62 insertions(+), 46 deletions(-) diff --git a/thanks-for-fixes.md b/thanks-for-fixes.md index 0df4ac00d..9af2a4509 100644 --- a/thanks-for-fixes.md +++ b/thanks-for-fixes.md @@ -9,32 +9,33 @@ There are several people who have contributed to the above mentioned several thousand changes and important improvements. We call out the extensive contributions of [Cody Boone -Ferguson](/winners.html#Cody_Boone_Ferguson) who is responsible for many of the -improvements including many, many **very complicated bug fixes** such as -[2001/anonymous](2001/anonymous/anonymous.c) and +Ferguson](https://www.ioccc.org/winners.html#Cody_Boone_Ferguson) who is +responsible for many of the improvements including many, many **very complicated +bug fixes** such as [2001/anonymous](2001/anonymous/anonymous.c) and [2004/burley](2004/burley/burley.c), making entries not require `-traditional-cpp` (which are **very complicated fixes**), fixing entries to compile with clang, fixing entries to work with macOS (some of which are **very complicated** such as [1998/schweikh1](1998/schweikh1/schweikh1.c)), providing alternate code where useful or necessary, fixing where possible dead links and -otherwise removing them, typo and consistency fixes and writing the [sgit -tool](https://github.com/xexyl/sgit) that we installed locally and have used to -easily run `sed` on files in the repository to help build the website. Thank -you **very much** for your extensive efforts in helping improve the IOCCC -presentation of past IOCCC winners and making many many past entries work with -modern systems! +otherwise removing them, typo and consistency fixes, improving **ALL +_Makefiles_** and writing the [sgit tool](https://github.com/xexyl/sgit) that we +installed locally and have used to easily run `sed` on files in the repository +to help build the website. Thank you **very much** for your extensive efforts +in helping improve the IOCCC presentation of past IOCCC winners and making many +many past entries work with modern systems! -[Yusuke Endoh](/winners.html#Yusuke_Endoh) supplied a number of important bug -fixes to a number of past IOCCC winners. Some of those fixes were **very -technically challenging** such as [1989/robison](1989/robison/robison.c), -[1990/cmills](1990/cmills/cmills.c), [1992/lush](1992/lush/lush.c) and -[2001/ctk](2001/ctk/ctk.c). Thank you **very much** for your help! +[Yusuke Endoh](https://www.ioccc.org/winners.html#Yusuke_Endoh) supplied a +number of important bug fixes to a number of past IOCCC winners. Some of those +fixes were **very technically challenging** such as +[1989/robison](1989/robison/robison.c), [1990/cmills](1990/cmills/cmills.c), +[1992/lush](1992/lush/lush.c) and [2001/ctk](2001/ctk/ctk.c). Thank you **very +much** for your help! -A good number of the [past winners of the IOCCC](winners.html) -tested, identified and helped correct and/or improve the write-ups -of fellow IOCCC winners for the year that they won. The list of -those past winners is too long to mention: nevertheless the -[IOCCC judges](judges.html) **very much appreciate** those who +A good number of the [past winners of the +IOCCC](https://www.ioccc.org/winners.html) tested, identified and helped correct +and/or improve the write-ups of fellow IOCCC winners for the year that they won. +The list of those past winners is too long to mention: nevertheless the [IOCCC +judges](https://www.ioccc.org/judges.html) **very much appreciate** those who helped improve the presentation of their fellow IOCCC winners. @@ -48,6 +49,17 @@ important contributions to the IOCCC presentation of past IOCCC winners. We are pleased to note the many contributions, **made since 2021 Jan 01**, on a winner by winner basis. +## Makefile fixes and improvements + +Cody made a variety of changes in all Makefiles, sometimes to get an entry to +work, all noted below, but he also **improved them all** in at least one or two +ways. For instance he changed the `LIBS` variable to `LDFLAGS` as that is the +standard variable. This simplifies compiling without having to modify the +Makefile which can be useful if something changes or if someone is trying to fix +an entry but forgets to change the Makefile or even if they don't want to make a +change due to a temporary test. These would of course depend on the compiler +invocation but since `LDFLAGS` is standard it is more likely to be used by +default so no need to check the Makefiles. ## [1984/anonymous](1984/anonymous/anonymous.c) ([README.md](1984/anonymous/README.md)) @@ -447,8 +459,7 @@ not having `.` in it). He notes that with an invocation in the try section will with macOS show what appears to be an error message but is actually okay. He gives more information in the [bugs.md](/bugs.md) file. -NOTE: as `btoa` is not common we used a ruby script from [Yusuke -Endoh](/winners.html#Yusuke_Endoh). +NOTE: as `btoa` is not common we used a ruby script from Yusuke. ## [1990/tbr](1990/tbr/tbr.c) ([README.md](1990/tbr/README.md])) @@ -593,10 +604,10 @@ loop). ## [1992/kivinen](1992/kivinen/kivinen.c) ([README.md](1992/kivinen/README.md])) -It was observed that on modern systems this goes much too quick. [Yusuke -Endoh](/winners.html#Yusuke_Endoh) created a patch that calls `usleep()` but -Cody thought the value was too slow so he made it a macro in the Makefile `Z`, -defaulting at 15000. You can reconfigure it like: +It was observed that on modern systems this goes much too quick. Yusuke created +a patch that calls `usleep()` but Cody thought the value was too slow so he made +it a macro in the Makefile `Z`, defaulting at 15000. You can reconfigure it +like: ```sh make clobber Z=1000 all @@ -648,10 +659,9 @@ encourage you to test this :-) This should NOT be fixed. ## [1993/jonth](1993/jonth/jonth.c) ([README.md](1993/jonth/README.md])) -Both Cody and [Yusuke Endoh](/winners.html#Yusuke_Endoh) fixed this so that it -will work with modern systems. Yusuke provided some fixes of the X code and Cody -fixed the C pre-processor directives so that it would compile. It used to be -that you could get away with code like: +Both Cody and Yusuke fixed this so that it will work with modern systems. Yusuke +provided some fixes of the X code and Cody fixed the C pre-processor directives +so that it would compile. It used to be that you could get away with code like: ```c G int i,j @@ -789,8 +799,7 @@ using gcc but macOS, having only clang by default (even the gcc binary Cody proposed a fix for this to compile with clang and Landon implemented it after some discussion. The reason Cody did not do it is because he thought it was the wrong output but as it happens the try section below was worded a bit -confusingly. He looked at [Yusuke Endoh's](/winners.html#Yusuke_Endoh) analysis -found +confusingly. He looked at Yusuke's] analysis found [here](https://mame-github-io.translate.goog/ioccc-ja-spoilers/1996/dalbec.html?_x_tr_sl=auto&_x_tr_tl=en&_x_tr_hl=en-US&_x_tr_pto=wapp) but he missed that Yusuke added a '...' after the result which made him think the fix was wrong. Cody also made the recommended change of the author to make @@ -1036,7 +1045,7 @@ checked prior to running the function just like the author did for the factorial 64-bit linux or macOS. See below portability notes as well as another fix in this entry by Yusuke. -### Portability notes: +## Portability notes: With a tip from Yusuke we rediscovered the author's [web page for this program](https://bellard.org/otcc/) where it is stated that this will only work @@ -1087,9 +1096,8 @@ also refers to sound devices in macOS). ## [2001/ctk](2001/ctk/ctk.c) ([README.md](2001/ctk/README.md])) -The ANSI escape codes were no longer valid but [Yusuke -Endoh](/winners.html#Yusuke_Endoh) provided a patch to fix the ANSI escape -codes. This works with macOS as well. +The ANSI escape codes were no longer valid but Yusuke provided a patch to fix +the ANSI escape codes. This works with macOS as well. ## [2001/dgbeards](2001/dgbeards/dgbeards.c) ([README.md](2001/dgbeards/README.md])) diff --git a/todo.md b/todo.md index eb27de5fd..1d3e685f0 100644 --- a/todo.md +++ b/todo.md @@ -1,5 +1,5 @@ # A todo list of known things to check and/or do -*Last updated: Wed 12 Jul 2023 11:54:12 UTC* +*Last updated: Fri 06 Oct 2023 10:45:23 UTC* This document is primarily for [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) as he (that is I :-) ) wanted a way @@ -17,7 +17,7 @@ this file the case is mostly _NOT_ been done). - Find entries with bugs as well INABIAF and add to [bugs.md](/bugs.md). As far as I am aware the ones that have not been checked are > 2011 (and two entries in 2011, vik and zucker) and possibly some of the earlier years. I - ([Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson)) have spent too + ([Cody Boone Ferguson](https://www.ioccc.org/winners.html#Cody_Boone_Ferguson)) have spent too much time when working on formatting the README.md files on finding problems out (and in some cases fixing or trying but not yet succeeding to fix an entry); if I did not do that I would be done with fixing the README.md files @@ -29,8 +29,8 @@ this file the case is mostly _NOT_ been done). - Resolve as many of the issues in [bugs.md](/bugs.md) with the exception of the INABIAF ones. This is likely not possible for all (one in particular comes to mind that abuses a bug in a now very old gcc version - this obviously cannot be -fixed but I added an alt version that does what it used to do) but many -certainly can be (and most have been) fixed. +fixed but I added an alt version that does what it used to do so it's fine) but +many certainly can be - and actually most have been - fixed. - Check for typos in README.md files. Although I did up through I believe 2011 I have to do another pass through all except that as of 12 July 2023 I went @@ -56,13 +56,14 @@ fix any issues. on one line only. Note that earlier spaces were being added to the end of the line but after discussion on GitHub it was decided it is preferable to have `
` instead. - * [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) has done many and - has some kind of record of what he's done but these can be added later by - having a list of years to check. However, as noted on 06 July 2023, all - years will have to be checked again so this might not be as important except - that the years not checked / fixed should only need one pass (but probably - will have a second pass anyway just to make sure things are good as seeing - things a second time is a good way to find additional errors). + * [Cody Boone + Ferguson](https://www.ioccc.org/winners.html#Cody_Boone_Ferguson) has done + many and has some kind of record of what he's done but these can be added + later by having a list of years to check. However, as noted on 06 July 2023, + all years will have to be checked again so this might not be as important + except that the years not checked / fixed should only need one pass (but + probably will have a second pass anyway just to make sure things are good as + seeing things a second time is a good way to find additional errors). - Remove addresses from older winning entries but (if known) keep country code + add country code and name to the respective JSON file in the [author](/author) @@ -124,3 +125,10 @@ there. link to point to the right location. * Do we need to update the links that point to GitHub raw content? I'm not sure. + + +- Remove WHERE CORRECT the references to those who fixed or provided alt code in +entries in the respective README.md files. This cannot be done without examining +each because some names are mentioned by the author. For instance I (Cody) can +think of at least three where I have been mentioned explicitly by the author: +one in 2018, one in 2019 and one in 2020.