From 8cb2cc6b7f334c951728d688f38ab69e6b720c5b Mon Sep 17 00:00:00 2001
From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com>
Date: Sun, 19 Feb 2023 07:11:21 -0800
Subject: [PATCH] Minor fixes in 2020/burton
In the check_be.sh script the default expected prog_be to be in the path
but that's not likely so make it ./prog_be instead.
Updated README.md to change prog.be to be prog_be and also add a note
about it segfaulting without an argument at the judges' comments, close
to the top.
The Makefile also warns on the entry segfaulting on no argument. This
way the viewers can have a warning. I will look at doing this with other
entries that might segfault too but later on.
I also added some example invocations to highlight something Dave Burton
mentioned in his remarks. Of course if he's against this I have no
problem there but I think it enhances the README.
---
2020/burton/Makefile | 2 ++
2020/burton/README.md | 18 ++++++++++++++----
2020/burton/check_be.sh | 2 +-
3 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/2020/burton/Makefile b/2020/burton/Makefile
index ccf753142..346e2a909 100644
--- a/2020/burton/Makefile
+++ b/2020/burton/Makefile
@@ -436,9 +436,11 @@ all: ${TARGET} ${DATA}
@${TRUE}
prog: prog.c
+ @echo "NOTE: this program will segfault without an argument."
${CC} ${CFLAGS} -DB=${B} -DI=${I} -DT=${T} -DS=${S} $< -o $@ ${LIBS}
prog_be: prog.c
+ @echo "NOTE: this program will segfault without an argument."
${CC} ${CFLAGS} -DB=${_B} -DI=${_I} -DT=${_T} -DS=${_S} $< -o $@ ${LIBS}
check: check.sh
diff --git a/2020/burton/README.md b/2020/burton/README.md
index 128aace9e..81c998235 100644
--- a/2020/burton/README.md
+++ b/2020/burton/README.md
@@ -24,18 +24,28 @@ The code for this entry can be found in prog.c
./prog 85
+ ./prog 128 128
+ ./prog 128 128 128
+ ./prog 128 128 128 128
+ # Can you determine why this shows strange output for the first and third
+ # but not the second? Can you find a pattern here? What happens if you
+ # specify different numbers?
+
### Selected Judges Remarks:
This tiny one-liner is a bit-twiddlers delight! It does all of the work
without looping.
To understand how it works, a good place to start is to look at the hex
-value that results when the two magic constants are XOR'ed.
+value that results when the two magic constants are XORed.
Once you've figured out what happens with one set of constants, how can
choosing new constants, but using the same computation generate a reversed
result?
+NOTE: this entry will dump core if you do not specify an argument.
+
+
## Author's comments:
Invoke this with a single non-negative integer less than 256, and a useful transformation occurs.
@@ -47,7 +57,7 @@ so they are truly configuration parameters, not logic.
### Notes
-One ping argument only. It will SEGV on zero arguments, and
+One ping argument only. It will segfault on zero arguments, and
display strange results if more than one argument.
Small, non-negative integers only. Useful range is 0 .. 511, sorta, for LE; 0 .. 255 for BE.
@@ -70,11 +80,11 @@ On a little-endian machine:
On a big-endian machine:
- clang -include stdio.h -include stdlib.h -Wall -Weverything -pedantic -DB=7091606191627001958LL -DI=6006468689561538903LL -DT=1 -DS=0 -o prog.be prog.c
+ clang -include stdio.h -include stdlib.h -Wall -Weverything -pedantic -DB=7091606191627001958LL -DI=6006468689561538903LL -DT=1 -DS=0 -o prog_be prog.c
You might be interested to compile it both ways on the same host, and try:
- ./prog 1; ./prog.be 1
+ ./prog 1; ./prog_be 1
-----------------------------------------------------------------------------------------------------
(c) Copyright 1984-2020, [Leo Broukhis, Simon Cooper, Landon Curt Noll][judges] - All rights reserved
diff --git a/2020/burton/check_be.sh b/2020/burton/check_be.sh
index 55a3a2a0e..903ff8749 100644
--- a/2020/burton/check_be.sh
+++ b/2020/burton/check_be.sh
@@ -1,7 +1,7 @@
#!/bin/sh
prog="$1"
-: ${prog:=prog_be}
+: ${prog:=./prog_be}
check_code() {
/bin/echo -n "$1 "; $prog $1 | rev