From 90efe469e31467dbc49c1f35e2d634b4cee7fa1a Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 3 Nov 2023 08:29:22 -0700 Subject: [PATCH] Remove outdated feature/bug in 1991/dds/README.md As the definition of a bug and feature was changed numerous times the feature or bug of if a file could not be opened for reading or a file could not be opened for writing was actually fixed to not crash. This has not been done in other entries and almost certainly won't be but with this one it was done (recently when there was a change of bug status in several entries as how the bugs.md file being referred to in the README.md files was improved) so this has inconvenient feature was removed from the README.md file. It was not noted in the thanks file either so that has been updated as well. --- 1991/dds/README.md | 14 -------------- thanks-for-fixes.md | 6 +++++- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/1991/dds/README.md b/1991/dds/README.md index 21c84d25b..2b4523b56 100644 --- a/1991/dds/README.md +++ b/1991/dds/README.md @@ -39,20 +39,6 @@ What happens if you give the program a C program like itself? Try: You'll get errors yes but what does the generated file look like? What about other types of files? -Please note that if the BASIC file cannot be opened for reading or the output -file cannot be opened for writing then this program will very likely crash or do -something funny. - -This is supposed to happen. As is written in the -[The Jargon File](http://catb.org/jargon/html/F/feature.html): - -``` -That's not a bug, that's a feature. -``` - -These are a mild nuisance but are considered a feature not a bug. We challenge -you to fix it for learning if you wish. See also [bugs.md](/bugs.md). - ## Judges' remarks: diff --git a/thanks-for-fixes.md b/thanks-for-fixes.md index d264f22d2..649f89fdf 100644 --- a/thanks-for-fixes.md +++ b/thanks-for-fixes.md @@ -1153,7 +1153,11 @@ The key to the string is that it rotates the character by `+1`. This was not immediately clear until reading the author's remarks so there was an alt version that was something of a kludge, running `make a` instead but that was removed. -Cody also fixed a typo in LANDER.BAS. +Cody also fixed a typo in LANDER.BAS and made it so that if a file could not be +opened for reading or a file could not be opened for writing it would not crash. +The definition of whether that should be a bug to fix or a feature to not fix +was pondered and changed numerous times and ultimately that problem with this +entry was fixed. It has not been done in all. ## [1991/fine](1991/fine/fine.c) ([README.md](1991/fine/README.md))