From a71766448335a19ec971a8f7cb5af2cee4cfa1f2 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Sun, 28 Jan 2024 11:55:55 -0800 Subject: [PATCH] Fix comments for shellcheck in 2014/maffiodo1 --- 2014/maffiodo1/giana.sh | 8 +++++++- 2014/maffiodo1/mario.sh | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/2014/maffiodo1/giana.sh b/2014/maffiodo1/giana.sh index 9fa2961af..2960e81ad 100755 --- a/2014/maffiodo1/giana.sh +++ b/2014/maffiodo1/giana.sh @@ -23,6 +23,12 @@ if [[ -z "$COLS" ]]; then COLS="640" fi -# ^---------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. +# We disable the useless cat warning of ShellCheck because the to use +# instructions have it and for such a long command line it's easier to deal +# with. Besides that it is dubious to claim there is such a thing as useless +# cat. +# +# SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. +# https://www.shellcheck.net/wiki/SC2002 # shellcheck disable=SC2002 cat giana.level | ./prog "$COLS" "$ROWS" 1000 300 192 168 giana.rgba giana8.wav 5459393 diff --git a/2014/maffiodo1/mario.sh b/2014/maffiodo1/mario.sh index 28e462c1d..7e9cb1a72 100755 --- a/2014/maffiodo1/mario.sh +++ b/2014/maffiodo1/mario.sh @@ -23,6 +23,12 @@ if [[ -z "$COLS" ]]; then COLS="640" fi -# ^---------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. +# We disable the useless cat warning of ShellCheck because the to use +# instructions have it and for such a long command line it's easier to deal +# with. Besides that it is dubious to claim there is such a thing as useless +# cat. +# +# SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. +# https://www.shellcheck.net/wiki/SC2002 # shellcheck disable=SC2002 cat mario.level | ./prog "$COLS" "$ROWS" 800 300 128 144 mario.rgba mario8.wav 10343679 && telnet telehack.com 23