From aa0468d03b3d6b6406a2fb010f54371a3726f113 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Mon, 6 May 2024 07:54:12 -0700 Subject: [PATCH] Fixes in presentation of 1988/isaak The uuencoded file isaak.encode was removed. Instead the output was put in isaak.output.txt. This has the same manifest priority as the encoded file. This file is strictly for historical remarks in the index.html file and not needed beyond that. Perhaps it should be in the secondary file list but that can be decided later. The file isaak.alt.c is now compilable. It is the isaak.orig.c that is not. The difference is with an old enough compiler/system it might be that the alt version will work. In modern systems the isaak.c will work. Manifest updated for the file changes. Thanks file updated with this and possibly other earlier changes in 1988. 1988 is not done yet but as these problems were found working on it I felt like I should commit them now too. --- 1988/isaak/.entry.json | 10 +++--- 1988/isaak/README.md | 37 +++++++++++--------- 1988/isaak/index.html | 33 +++++++++-------- 1988/isaak/isaak.alt.c | 37 ++++++++++---------- 1988/isaak/isaak.encode | 68 ------------------------------------ 1988/isaak/isaak.output.txt | 39 +++++++++++++++++++++ thanks-for-help.html | 25 +++++++------ thanks-for-help.md | 27 +++++++------- tmp/manifest.csv | 2 +- tmp/manifest.numbers | Bin 1307005 -> 1329559 bytes tmp/path_list.built.txt | 1 + tmp/path_list.found.txt | 2 +- tmp/path_list.manifest.txt | 2 +- tmp/path_list.required.txt | 1 - 14 files changed, 134 insertions(+), 150 deletions(-) delete mode 100644 1988/isaak/isaak.encode create mode 100644 1988/isaak/isaak.output.txt diff --git a/1988/isaak/.entry.json b/1988/isaak/.entry.json index bd9e0c046..5dfe31bba 100644 --- a/1988/isaak/.entry.json +++ b/1988/isaak/.entry.json @@ -42,12 +42,12 @@ "entry_text" : "original source" }, { - "file_path" : "isaak.encode", + "file_path" : "isaak.output.txt", "inventory_order" : 180, - "OK_to_edit" : true, - "display_as" : "xxencode", - "display_via_github" : true, - "entry_text" : "uuencoded sample output" + "OK_to_edit" : false, + "display_as" : "text", + "display_via_github" : false, + "entry_text" : "program output" }, { "file_path" : "1988_isaak.tar.bz2", diff --git a/1988/isaak/README.md b/1988/isaak/README.md index 94fad95cb..06b6a0b40 100644 --- a/1988/isaak/README.md +++ b/1988/isaak/README.md @@ -18,8 +18,9 @@ code](#alternate-code) below. ## Alternate code: -The original version of this code is in [isaak.alt.c](%%REPO_URL%%/1988/isaak/isaak.alt.c). -The original entry starts with the line: +The original version of this code is in +[isaak.alt.c](%%REPO_URL%%/1988/isaak/isaak.alt.c), with a minor fix so that it +will compile. The original entry starts with the line: ``` main(){}; @@ -29,10 +30,11 @@ This works on some systems. Why? Note that `#include ` is given on the last line. Why is this needed? Note the unusual calls to `sprintf(3)`. This version also relied on being able to define `#define` to something else and -using that macro for `#define`. +using that macro for `#define`. This was fixed, however, so that you can at +least compile it in modern systems. -This version will not likely work on modern systems if you can even get it to -compile. +This version will not likely work on modern systems even though you should be +able to compile it. ### Alternate build: @@ -41,6 +43,9 @@ compile. make alt ``` + +### Alternate use: + Use `isaak.alt` as you would `isaak` above. @@ -49,11 +54,13 @@ Use `isaak.alt` as you would `isaak` above. The program relies heavily on ASCII. Don't even think of running it on an EBCDIC machine. -### Historical notes about the original entry: -NOTE: If you named the file anything other than [isaak.c](%%REPO_URL%%/1988/isaak/isaak.c), you had to -change the `#include` on line 6. This limitation has been fixed by using the -`__FILE__` macro. +### Historical notes about the original entry + +NOTE: If you named the file anything other than `isaak.c`, you had to +change the `#include` on line 6. This limitation has been fixed in +[isaak.c](%%REPO_URL%%/1988/isaak/isaak.c) and +[isaak.alt.c](%%REPO_URL%%/1988/isaak/isaak.alt.c) by using the `__FILE__` macro. NOTE: The use of null comments to separate macros to construct different tokens from a single macro (e.g., `"O/**/O"` creates either `++` or `--` by defining @@ -62,15 +69,11 @@ from a single macro (e.g., `"O/**/O"` creates either `++` or `--` by defining NOTE: Most System V machines were not be able to execute this program correctly due to the fact that BSD style systems have an `sprintf(3)` that returns a `char *`. Due to the above problems, we placed the output of this program in the -file: isaak.encode. To read this file do. +file [isaak.output.txt](isaak.output.txt). -``` - uudecode < isaak.encode - cat isaak.output -``` - -Since this was fixed, this file is not strictly necessary. See the -[isaak.alt.c](%%REPO_URL%%/1988/isaak/isaak.alt.c) for the original source. +Since this was fixed, this file is not strictly necessary, but we keep it for +historical purposes (decoded as it used to be uuencoded). See the +[isaak.orig.c](%%REPO_URL%%/1988/isaak/isaak.orig.c) for the original source. FYI: We are likely to be more strict about portability in the future. diff --git a/1988/isaak/index.html b/1988/isaak/index.html index a23f3908a..88ea69179 100644 --- a/1988/isaak/index.html +++ b/1988/isaak/index.html @@ -403,35 +403,38 @@ code below.

To use:

    ./isaak

Alternate code:

-

The original version of this code is in isaak.alt.c. -The original entry starts with the line:

+

The original version of this code is in +isaak.alt.c, with a minor fix so that it +will compile. The original entry starts with the line:

    main(){};

This works on some systems. Why? Note that #include <stdio.h> is given on the last line. Why is this needed? Note the unusual calls to sprintf(3).

This version also relied on being able to define #define to something else and -using that macro for #define.

-

This version will not likely work on modern systems if you can even get it to -compile.

+using that macro for #define. This was fixed, however, so that you can at +least compile it in modern systems.

+

This version will not likely work on modern systems even though you should be +able to compile it.

Alternate build:

    make alt
+

Alternate use:

Use isaak.alt as you would isaak above.

Judges’ remarks:

The program relies heavily on ASCII. Don’t even think of running it on an EBCDIC machine.

-

Historical notes about the original entry:

-

NOTE: If you named the file anything other than isaak.c, you had to -change the #include on line 6. This limitation has been fixed by using the -__FILE__ macro.

+

Historical notes about the original entry

+

NOTE: If you named the file anything other than isaak.c, you had to +change the #include on line 6. This limitation has been fixed in +isaak.c and +isaak.alt.c by using the __FILE__ macro.

NOTE: The use of null comments to separate macros to construct different tokens from a single macro (e.g., "O/**/O" creates either ++ or -- by defining O to be + or -) may cause some strict ANSI C preprocessors to object.

NOTE: Most System V machines were not be able to execute this program correctly due to the fact that BSD style systems have an sprintf(3) that returns a char *. Due to the above problems, we placed the output of this program in the -file: isaak.encode. To read this file do.

-
    uudecode < isaak.encode
-    cat isaak.output
-

Since this was fixed, this file is not strictly necessary. See the -isaak.alt.c for the original source.

+file isaak.output.txt.

+

Since this was fixed, this file is not strictly necessary, but we keep it for +historical purposes (decoded as it used to be uuencoded). See the +isaak.orig.c for the original source.

FYI: We are likely to be more strict about portability in the future.

Author’s remarks:

No remarks were provided by the author.

@@ -464,7 +467,7 @@ file: isaak.encode. To read this file do.

  • Makefile - entry Makefile
  • isaak.alt.c - alternate code
  • isaak.orig.c - original source
    • -
  • isaak.encode - uuencoded sample output
    • +
  • isaak.output.txt - program output

    • Secondary files