From b52c1fde23be2ffee875187b31f958c152b4fd1e Mon Sep 17 00:00:00 2001
From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com>
Date: Sat, 4 Nov 2023 04:11:39 -0700
Subject: [PATCH] Fix 1990/jaw/btoa script

This now lets the command in the judges' remarks:

    echo "Quartz glyph jocks vend, fix, BMW." | compress | ./btoa | ./jaw

not report just:

    oops
    oops

and instead it outputs data which suggests, I believe, that the program
is not buggy but instead the script had to have the 'xbtoa' changed to
'btoa'.

Updated bugs.md and thanks-for-fixes.md and README.md file too.

Other changes were made to thanks file as they are more appropriate than
in the README.md (of 1990/theorem) after the (once again sounding like
a broken record) vastly superior idea of the thanks file came up. This
addition here is unintentional; it was just already there but not ready
for committing as 1990/theorem/README.md was not yet ready. That file
will be committed today.
---
 1990/jaw/README.md  | 13 +------------
 1990/jaw/btoa       |  5 +++--
 bugs.md             | 27 +--------------------------
 thanks-for-fixes.md | 25 +++++++++++++++++--------
 4 files changed, 22 insertions(+), 48 deletions(-)

diff --git a/1990/jaw/README.md b/1990/jaw/README.md
index cf403a1f5..2a2a5ccc7 100644
--- a/1990/jaw/README.md
+++ b/1990/jaw/README.md
@@ -17,17 +17,6 @@ make all
 ```
 
 
-### Bugs and (Mis)features:
-
-The current status of this entry is:
-
-```
-STATUS: known bug - please help us fix
-```
-
-For more detailed information see [1990 jaw in bugs.md](/bugs.md#1990-jaw).
-
-
 ### Try:
 
 To test the official C entry, one might try:
@@ -40,7 +29,7 @@ which should apply the identity transformation to a minimal holoalphabetic
 sentence.
 
 
-Also try:
+#### Also try:
 
 ```sh
 ./try.sh
diff --git a/1990/jaw/btoa b/1990/jaw/btoa
index cbc59a7c5..cd73f6953 100755
--- a/1990/jaw/btoa
+++ b/1990/jaw/btoa
@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-puts "xbtoa Begin"
+
+puts "btoa Begin"
 data = $<.read
 n, e, s, r = data.bytesize, 0, 0, 0
 (-n % 4).times { data << 0 }
@@ -9,4 +10,4 @@ end
 data.unpack("N*").flat_map do |v|
   v == 0 ? [?z.ord] : (0..4).map {|i| v / 85**(4 - i) % 85 + 33 }
 end.pack("C*").scan(/.{1,78}/) { puts $& }
-puts "xbtoa End N %d %x E %x S %x R %x" % [n, n, e, s, r]
+puts "btoa End N %d %x E %x S %x R %x" % [n, n, e, s, r]
diff --git a/bugs.md b/bugs.md
index 7ad629e95..0e5620b5c 100644
--- a/bugs.md
+++ b/bugs.md
@@ -658,33 +658,10 @@ errors.
 That's about all I can say for how it works as other things have to be done too.
 Enjoy! :-)
 
+
 # 1990
 
 
-## 1990 jaw
-
-### STATUS: known bug - please help us fix
-### Source code: [1990/jaw/jaw.c](1990/jaw/jaw.c)
-### Information: [1990/jaw/README.md](1990/jaw/README.md)
-
-The command:
-
-```sh
-echo "Quartz glyph jocks vend, fix, BMW." | compress | ./btoa | ./jaw
-```
-
-just prints:
-
-```
-$ echo "Quartz glyph jocks vend, fix, BMW." | compress | ./btoa | ./jaw
-oops
-oops
-```
-
-Do you have a fix? We welcome it (Cody does have an idea and will look at it
-later but we also don't know what it's supposed to do now)!
-
-
 ## 1990 theorem
 
 ### STATUS: INABIAF - please **DO NOT** fix
@@ -701,8 +678,6 @@ where this occurred was fixed but this one should not be fixed. Thank you.
 # 1991
 
 
-## 1991 dds
-
 ## 1991 westley
 
 ### STATUS: INABIAF - please **DO NOT** fix
diff --git a/thanks-for-fixes.md b/thanks-for-fixes.md
index 9bb649664..d5770fa29 100644
--- a/thanks-for-fixes.md
+++ b/thanks-for-fixes.md
@@ -959,10 +959,9 @@ is 0 it shows what looks like an error.
 He added the [try.sh](1990/jaw/try.sh) to run the commands that we suggested at
 the time.
 
-However, there is a known bug still, see [1990 jaw in
-bugs.md](/bugs.md#1990-jaw) for details.
-
-NOTE: as `btoa` is not common we used a ruby script from Yusuke.
+NOTE: as `btoa` is not common we used a ruby script from Yusuke but with a minor
+fix applied by Cody that made the program just show `oops` twice from invalid
+input.
 
 
 ## [1990/pjr](1990/pjr/pjr.c) ([README.md](1990/pjr/README.md]))
@@ -1020,14 +1019,24 @@ again (since it did not work anyway a segfault prevention was added here). He
 also fixed some array addressing (some of which might not be strictly necessary
 but as he was testing the `fibonacci.c` bug he ended up changing it anyway).
 
-Finally he changed this program to use `fgets()` not `gets()` to make it safer
+BTW: why can't the fix:
+
+```c
+if (a[1]==NULL||a[2]==NULL||a[3]==NULL||a[4]==NULL||a[5]==NULL) return 1;
+```
+
+be changed to just test the value of `A` when `a` is argv and `A` is argc?
+
+
+Finally Cody changed this program to use `fgets()` not `gets()` to make it safer
 and to prevent a warning about `gets()` at linking or runtime. Since this
 program is so incredible the extra fixes were deemed worth having and this is why
 it was done.
 
-Cody disabled a warning in the Makefile that proved to be a problem only with
-clang in linux but which was defaulting to an error. This way was the simplest
-way to deal with the problem in question due to the way the entry works.
+Cody later disabled a warning in the Makefile that proved to be a problem only
+with clang in linux but which was defaulting to an error. This way was the
+simplest way to deal with the problem in question due to the way the entry
+works.
 
 Yusuke pointed out that `atof` nowadays needs `#include <stdlib.h>` which was
 used in order to get this to work initially (prior to this output was there but