From b741325af8f261f46f128baf16afaef08cf129c9 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Thu, 6 Jun 2024 07:29:26 -0700 Subject: [PATCH] Restore one INABIAF in 1990/westley The other one cannot be restored or at least should not be as it floods the screen in an unsuspecting way. If no arg is specified though, it now will likely crash (previously because of the use of argv[1] later in the code but now to prevent the code from flooding the screen if the number is < 0). --- 1990/westley/Makefile | 3 +- 1990/westley/README.md | 12 +++ 1990/westley/index.html | 4 + 1990/westley/westley.c | 2 +- bugs.html | 179 +++++++++++++++++++++------------------- bugs.md | 14 ++++ thanks-for-help.html | 8 +- thanks-for-help.md | 9 +- 8 files changed, 132 insertions(+), 99 deletions(-) diff --git a/1990/westley/Makefile b/1990/westley/Makefile index 28256e308..8f614dfd1 100644 --- a/1990/westley/Makefile +++ b/1990/westley/Makefile @@ -137,8 +137,7 @@ all: data ${TARGET} sandwich supernova deep_magic magic charon pluto ${PROG}: ${PROG}.c - @echo "NOTE: this will very likely crash without an arg and will enter an infinite loop" - @echo "with an arg that is not a number > 0." + @echo "NOTE: this will very likely crash without an arg" ${CC} ${CFLAGS} $< -o $@ ${LDFLAGS} # alternative executable diff --git a/1990/westley/README.md b/1990/westley/README.md index 27b6fe30c..7b9db3580 100644 --- a/1990/westley/README.md +++ b/1990/westley/README.md @@ -5,6 +5,18 @@ ``` +### Bugs and (Mis)features: + +The current status of this entry is: + +``` + STATUS: INABIAF - please **DO NOT** fix +``` + +For more detailed information see [1990/westley in bugs.html](../../bugs.html#1990_westley). + + + ## To use: ``` diff --git a/1990/westley/index.html b/1990/westley/index.html index 979bdf3ef..bae4369f0 100644 --- a/1990/westley/index.html +++ b/1990/westley/index.html @@ -403,6 +403,10 @@ Location: US - United States of America

To build:

    make all
+

Bugs and (Mis)features:

+

The current status of this entry is:

+
    STATUS: INABIAF - please **DO NOT** fix
+

For more detailed information see 1990/westley in bugs.html.

To use:

    ./westley <number>

The number should be greater than 0.

diff --git a/1990/westley/westley.c b/1990/westley/westley.c index 635e8aa44..50fe5facc 100644 --- a/1990/westley/westley.c +++ b/1990/westley/westley.c @@ -11,7 +11,7 @@ char*lie; dear; (char)lotte--; - if (ly < 2 || atoi(die[1])<1) exit(1); + if (atoi(die[1])<1) exit(1); for(get= !me;; not){ 1 - out & out ;lie;{ diff --git a/bugs.html b/bugs.html index a4d41022d..e63495c49 100644 --- a/bugs.html +++ b/bugs.html @@ -999,6 +999,15 @@ prevented this from working properly (including segfaults) but one thing to note is that if you pass two zeroes to theorem_bkp or fibonacci the program will enter an infinite loop, printing 0 over and over again; another condition where this occurred was fixed but this one should not be fixed. Thank you.

+
+

1990/westley

+
+

STATUS: INABIAF - please DO NOT fix

+

Source code: 1990/westley/westley.c

+

Information: 1990/westley/index.html

+

Although Cody fixed this to not enter an infinite loop if the arg (converted to +a number) is < 0 the lack of an arg check at all was kept in to make it like the +original. The reason for the < 0 check is it floods the screen.


1991

@@ -1007,7 +1016,7 @@ where this occurred was fixed but this one should not be fixed. Thank you.

1991/buzzard

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1991/buzzard/buzzard.c

Information: 1991/buzzard/index.html

If the maze file cannot be opened, either because the path specified does not @@ -1015,9 +1024,9 @@ exist or because the default (whatever the source file was at compilation time) file does not exist in the directory, this program will very likely crash.

This is a feature, not a bug.

-

1991/westley

+

1991/westley

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1991/westley/westley.c

Information: 1991/westley/index.html

There is a very simple way to always win. The program doesn’t catch you and as @@ -1034,7 +1043,7 @@ when you’re cheating it ends up winning! Can you figure that out as well?

1992/adrian

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1992/adrian/adrian.c

Information: 1992/adrian/index.html

The author stated that if the file cannot be opened then it will print a system @@ -1195,16 +1204,16 @@ than that. For instance this is what it looks like with clang:

1992/vern

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1992/vern/vern.c

Information: 1992/vern/index.html

When your own checkmate is imminent it prints "Har har" but does not exit so it can ‘rub your nose in defeat’, as the author puts it. You will have to exit it yourself through ctrl-c or killing it in some other fashion.

-

1992/westley

+

1992/westley

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1992/westley/westley.c

Information: 1992/westley/index.html

Cody improved the usability of this program by making it so that as long as the @@ -1230,7 +1239,7 @@ not a misunderstanding).

1993


-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1993/ant/ant.c

Information: 1993/ant/index.html

The author stated that:

@@ -1253,7 +1262,7 @@ system), this entry just shows a blank screen.

1993/lmfjyh

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1993/lmfjyh/lmfjyh.c

Information: 1993/lmfjyh/index.html

This entry relied on a bug in gcc that was fixed with gcc version 2.3.3. This @@ -1263,7 +1272,7 @@ the index.html file for details.

1993/rince

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1993/rince/rince.c

Information: 1993/rince/index.html

Although the code checks if the file can be opened or not, badly formatted files @@ -1273,7 +1282,7 @@ through ctrl-c or such.

1993/schnitzi

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1993/schnitzi/schnitzi.c

Information: 1993/schnitzi/index.html

If the file cannot be opened it will very likely segfault. This should not be @@ -1299,7 +1308,7 @@ question you might cause an error. For instance don’t do this:

Of course if you do something like:

    What is 'foo'?

it will work fine.

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1993/vanb/vanb.c

Information: 1993/vanb/index.html

No spaces are allowed in the expression.

@@ -1315,7 +1324,7 @@ not d-46.

1994/dodsond2

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1994/dodsond2/dodsond2.c

Information: 1994/dodsond2/index.html

When you initiate shooting via the s command you immediately lose an arrow @@ -1325,7 +1334,7 @@ pit room you will end up dying even though you didn’t explicitly move there.

1994/ldb

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1994/ldb/ldb.c

Information: 1994/ldb/index.html

Cody Boone Ferguson fixed this to compile @@ -1428,7 +1437,7 @@ compiled!

1994/shapiro

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1994/shapiro/shapiro.c

Information: 1994/shapiro/index.html

This program will likely crash if the source code file (by the name of the file @@ -1475,7 +1484,7 @@ doesn’t break something else.

1995/cdua

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1995/cdua/cdua.c

Information: 1995/cdua/index.html

This did not originally compile under macOS and after it did compile under @@ -1507,7 +1516,7 @@ it would be good if it was fixed.

1995/savastio

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1995/savastio/savastio.c

Information: 1995/savastio/index.html

This program expects a POSITIVE number. If you specify a negative number it will @@ -1572,7 +1581,7 @@ almost be done except that some of the output of the

1996/jonth

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1996/jonth/jonth.c

Information: 1996/jonth/index.html

If X is not running this program will very likely crash or do something funny. @@ -1615,7 +1624,7 @@ to the page as well! You’ll have IOCCC fame for reviving a pootifier! :-)

1998/schnitzi

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 1998/schnitzi/schnitzi.c

Information: 1998/schnitzi/index.html

A point worth considering is that as the number passed into the program gets @@ -1772,7 +1781,7 @@ on the stack at that point:

5

which might (?) suggest that the + operator is unimplemented. Unfortunately it has been many years since I have used perl and I was never a guru either.

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

The author states that in perl < 5.6.0 there is a bug with a core dump in what they said is in Perl_sv_upgrade. As this is documented it is not considered a bug to be fixed. For the curious this will crash in macOS. Cody notes that the @@ -1814,7 +1823,7 @@ of 92 warnings! Nonetheless neither works okay and both crash.

2000/primenum

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2000/primenum/primenum.c

Information: 2000/primenum/index.html

This program does not do what you might think it does! Running it like:

@@ -1832,7 +1841,7 @@ make a pull request.

2000/rince

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2000/rince/rince.c

Information: 2000/rince/index.html

If DISPLAY is not set the program will very likely crash, do something strange @@ -1846,7 +1855,7 @@ fire! :-) ).

2001/anonymous

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2001/anonymous/anonymous.c

Information: 2001/anonymous/index.html

Cody Boone Ferguson fixed this so that it @@ -1865,7 +1874,7 @@ elves of Imladris :-(

2001/bellard

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

STATUS: doesn’t work with some platforms - please help us fix

Source code: 2001/bellard/bellard.c

Information: 2001/bellard/index.html

@@ -1914,14 +1923,14 @@ before the fixes there.

2001/cheong

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2001/cheong/cheong.c

Information: 2001/cheong/index.html

This program will crash without an arg.

2001/dgbeards

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2001/dgbeards/dgbeards.c

Information: 2001/dgbeards/index.html

This program deliberately crashes if it loses (which is what it aims to do).

@@ -1942,7 +1951,7 @@ appreciate your help!

2001/kev

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2001/kev/kev.c

Information: 2001/kev/index.html

Sometimes when one player presses q it will result in broken pipe on the other @@ -1960,7 +1969,7 @@ set. In other words both have to be ASCII or EBCDIC - not one of each.

2001/ollinger

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2001/ollinger/ollinger.c

Information: 2001/ollinger/index.html

This program will very likely crash or do something unexpected if you do not @@ -1976,14 +1985,14 @@ wanted to install it as a tool but this is missing.

2001/schweikh

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2001/schweikh/schweikh.c

Information: 2001/schweikh/index.html

The glob pattern must match the whole string. See the author’s comments for details and a workaround.

There’s also no way to escape meta characters.

-

2001/westley

+

2001/westley

STATUS: uses gets() - change to fgets() if possible

Source code: 2001/westley/westley.c

@@ -2144,13 +2153,13 @@ compile under clang. The following patch was applied:

gavin_files: boot.b lilo.conf prim gavin_install.txt

The current (Makefile was modified to try and fit into the current IOCCC build environment.

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

See known features in the index.html for things that are not bugs but documented (mis)features.

2004/jdalbec

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2004/jdalbec/jdalbec.c

Information: 2004/jdalbec/index.html

The author stated that:

@@ -2175,7 +2184,7 @@ things that are not bugs but documented (mis)features.

2004/sds

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2004/sds/sds.c

Information: 2004/sds/index.html

The generated code will very likely segfault or do something not intended if not @@ -2188,7 +2197,7 @@ given the right args. See the index.html file for the correct syntax.

2005/anon

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2005/anon/anon.c

Information: 2005/anon/index.html

This program sometimes will create unsolvable puzzles :-) just to hook you. @@ -2202,7 +2211,7 @@ dimensions. Try 100 100 100 for instance and see what happens!

2005/giljade

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2005/giljade/giljade.c

Information: 2005/giljade/index.html

This entry will very likely segfault or do something strange if the source code @@ -2211,7 +2220,7 @@ does not exist.

2005/mikeash

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2005/mikeash/mikeash.c

Information: 2005/mikeash/index.html

The author states:

@@ -2245,7 +2254,7 @@ for running itself.

2005/mynx

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2005/mynx/mynx.c

Information: 2005/mynx/index.html

Cody Boone Ferguson notes that, though @@ -2259,7 +2268,7 @@ website itself.

2005/sykes

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2005/sykes/sykes.c

Information: 2005/sykes/index.html

The author stated the below points of interest.

@@ -2300,7 +2309,7 @@ with at least computer.tofu input file:

2006/borsanyi

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2006/borsanyi/borsanyi.c

Information: 2006/borsanyi/index.html

The string specified must be <= 42 characters and may only consist of the @@ -2309,7 +2318,7 @@ with possibly corrupt GIF files.

2006/hamre

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2006/hamre/hamre.c

Information: 2006/hamre/index.html

This program will likely crash or do something funny without an arg.

@@ -2328,12 +2337,12 @@ but you are welcome to try and fix it.

provide it as an additional alt version. Fixing this is very likely to be very challenging and in some systems it will not be possible to fix but you are welcome to try and fix it if you wish to!

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Incorrect formulas will ungracefully crash the program.

2006/stewart

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2006/stewart/stewart.c

Information: 2006/stewart/index.html

This program will likely crash or do something funny if the file cannot be @@ -2341,7 +2350,7 @@ opened. The number of args is however checked.

2006/sykes1

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2006/sykes1/sykes1.c

Information: 2006/sykes1/index.html

The author stated:

@@ -2358,7 +2367,7 @@ opened. The number of args is however checked.

2006/toledo2

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2006/toledo2/toledo2.c

Information: 2006/toledo2/index.html

Cody Boone Ferguson fixed this program to @@ -2405,7 +2414,7 @@ case-sensitive.

2011/borsanyi

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

Source code: 2011/borsanyi/borsanyi.c

Information: 2011/borsanyi/index.html

For a great amount of data points the program will crash, depending on your @@ -2428,7 +2437,7 @@ bins at the edges.

instead being something else entirely. The Internet Wayback Machine, although it archived it, did not load scripts. Do you know if the domain was moved? Do you have an archive or mirror? Please provide us it! Thank you.

-

STATUS: INABIAF - please DO NOT fix

+

STATUS: INABIAF - please DO NOT fix

The author states the following: