From b7eacf4849be5c6af2443ce9e61d38d164589a26 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Thu, 11 Jan 2024 06:07:01 -0800 Subject: [PATCH] Further fixes to 1998/fanf for clang Some versions of clang need -Wno-int-conversion. --- 1998/fanf/Makefile | 3 ++- thanks-for-help.md | 7 +++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/1998/fanf/Makefile b/1998/fanf/Makefile index 7299dfb54..6c88f55ed 100644 --- a/1998/fanf/Makefile +++ b/1998/fanf/Makefile @@ -38,7 +38,8 @@ include ../../var.mk # Common C compiler warnings to silence # -CSILENCE= -Wno-pointer-bool-conversion -Wno-unused-parameter -Wno-main -Wno-implicit-function-declaration +CSILENCE= -Wno-pointer-bool-conversion -Wno-unused-parameter -Wno-main -Wno-implicit-function-declaration \ + -Wno-int-conversion # Common C compiler warning flags # diff --git a/thanks-for-help.md b/thanks-for-help.md index 8d3ffa961..a9e8087ea 100644 --- a/thanks-for-help.md +++ b/thanks-for-help.md @@ -2134,8 +2134,11 @@ Cody also added a second arg to `main()` out of an abundance of caution as some versions of clang whine about the number of args to `main()`. These versions claim that only 0, 2 or 3 are allowed but it does allow 1 anyway. It is quite possible though that this will change so it is fixed in case this happens. As it -is mostly just through the C pre-processor Cody added a new macro to do -translate to the rest of `main()`'s args. +is mostly just through the C pre-processor Cody added a new macro to make the +code look like the original with just an extra arg. + +In some versions of clang `-Wno-int-conversion` had to be added to the +`CSILENCE` variable of the Makefile. Cody also added the [try.sh](/1998/fanf/try.sh) script to show the output of some of the expressions that we selected.