Merge pull request #960 from xexyl/sgit-typos

Typo fixes in sgit (comments in script, README.md)
This commit is contained in:
Landon Curt Noll authored and GitHub committed 2023-09-21 17:35:43 -07:00
commit dc75047627
2 files changed
+5 -6

No files matched your search

+2 -3
View File
@@ -177,9 +177,8 @@ There are probably other limitations but it works well for what I needed.
## Bugs ## Bugs
None known but it does not try and determine which files have match the None known but it does not try and determine which files match the patterns.
patterns. This would likely greatly complicate the script and is I feel This would likely greatly complicate the script and is I feel unneeded.
unneeded.
If you specify invalid `sed` commands obviously there will be problems. If you If you specify invalid `sed` commands obviously there will be problems. If you
specify invalid `sed` options there will possibly be problems as well. specify invalid `sed` options there will possibly be problems as well.
+3 -3
View File
@@ -141,11 +141,11 @@ fi
# This might not the best performance because it does this on all files of the # This might not the best performance because it does this on all files of the
# glob rather than only those files matched by the glob with matching text but # glob rather than only those files matched by the glob with matching text but
# it's better than it used to be (it used to run git ls-files on the repo for # it's better than it used to be (it used to run git ls-files on the repo for
# each sed command so the more you had the slow it would become as it had to get # each sed command so the more you had the slower it would become as it had to
# the list of files each time!). # get the list of files each time!).
# #
# A better approach would be to somehow use git grep to find files that match # A better approach would be to somehow use git grep to find files that match
# but this would complicate the command line (at least in anyway I can think of # but this would complicate the command line (at least in any way I can think of
# how to do it) so we do it on all files in the repo. # how to do it) so we do it on all files in the repo.
# #
# But these would possibly require additional args to the command and # But these would possibly require additional args to the command and