Change INABIAF status in 1992/westley
It was an error to fix the segfault without enough args in 1992/westley as it does not in fact affect the usability of the program and that's the only time a segfault should be fixed except by anyone but the author themselves. This commit required also changing the alt code (that I added based on the author's remarks) as well as the README.md, bugs.md and thanks-for-fixes.md.
This commit is contained in:
1 parent
3500226a0c
commit
dfabb616f2
5 files changed
+20
-11
No files matched your search
@@ -44,7 +44,7 @@ show correctly!
|
|||||||
|
|
||||||
### Alternative code:
|
### Alternative code:
|
||||||
|
|
||||||
The author provided a version for the US. To build:
|
The author provided a version for the US which we added. To build:
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
make alt
|
make alt
|
||||||
@@ -54,6 +54,10 @@ Use `westley.alt` as you would `whereami` above.
|
|||||||
|
|
||||||
NOTE: this alternative version also needs a terminal that wraps at 80 columns.
|
NOTE: this alternative version also needs a terminal that wraps at 80 columns.
|
||||||
|
|
||||||
|
### INABIAF - it's not a bug it's a feature! :-)
|
||||||
|
|
||||||
|
This program and the alternate version will very likely crash or nuke the world
|
||||||
|
without enough args. This should not be fixed.
|
||||||
|
|
||||||
## Judges' remarks:
|
## Judges' remarks:
|
||||||
|
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
main(l,a,n,d)char**a,**n,**d;{int N=n,D=d;if(l>2){for(D=atoi(a[1])/2*80-atoi(a[2])-2043;
|
main(l,a,n,d)char**a,**n,**d;{int N=n,D=d;for(D=atoi(a[1])/2*80-atoi(a[2])-2043;
|
||||||
N="bnaBCOCXdBBHGYdAP[A M E R I C A].AqandkmavX|ELC}BOCd"
|
N="bnaBCOCXdBBHGYdAP[A M E R I C A].AqandkmavX|ELC}BOCd"
|
||||||
[l++-3];)for(;N-->64;)putchar(!D+++33^l&1);}}
|
[l++-3];)for(;N-->64;)putchar(!D+++33^l&1);}
|
||||||
|
|
||||||
@@ -1,7 +1,7 @@
|
|||||||
main(l
|
main(l
|
||||||
,a)char**a;{int n;int d;
|
,a)char**a;{int n;int
|
||||||
if (l>2)for(d=atoi(a[1])/10
|
d;for(d=atoi(a[1])/10*80-
|
||||||
*80-atoi(a[2])/5-596;n="@NKA\
|
atoi(a[2])/5-596;n="@NKA\
|
||||||
CLCCGZAAQBEAADAFaISADJABBA^\
|
CLCCGZAAQBEAADAFaISADJABBA^\
|
||||||
SNLGAQABDAXIMBAACTBATAHDBAN\
|
SNLGAQABDAXIMBAACTBATAHDBAN\
|
||||||
ZcEMMCCCCAAhEIJFAEAAABAfHJE\
|
ZcEMMCCCCAAhEIJFAEAAABAfHJE\
|
||||||
|
|||||||
@@ -676,6 +676,12 @@ work but it only works with gcc. Unfortunately due to the way the entry works
|
|||||||
and the fact that other compilers like clang have different warnings and errors
|
and the fact that other compilers like clang have different warnings and errors
|
||||||
this simply does not work with them. Can you help us?
|
this simply does not work with them. Can you help us?
|
||||||
|
|
||||||
|
## [1992/westley](1992/westley/westley.c) ([README.md](1992/westley/README.md))
|
||||||
|
## STATUS: INABIAF - please **DO NOT** fix
|
||||||
|
|
||||||
|
This entry will very likely crash or nuke the world without enough args. This is
|
||||||
|
not considered a bug but a feature and should not be fixed in the repo.
|
||||||
|
|
||||||
|
|
||||||
# 1993
|
# 1993
|
||||||
|
|
||||||
|
|||||||
+4
-5
@@ -452,11 +452,10 @@ clang due to different compiler messages.
|
|||||||
|
|
||||||
## [1992/westley](1992/westley/westley.c) ([README.md](1992/westley/README.md]))
|
## [1992/westley](1992/westley/westley.c) ([README.md](1992/westley/README.md]))
|
||||||
|
|
||||||
Cody fixed this for clang by changing the third and fourth arg of `main()` to be
|
Cody fixed this to work for clang by changing the third and fourth arg of
|
||||||
ints inside `main()`; clang requires args 2 - 4 to be `char **`. He also fixed
|
`main()` to be ints inside `main()`; clang requires args 2 - 4 to be `char **`.
|
||||||
it so that the program would not segfault if not enough args were specified. He
|
He also added the alternate version that the author gave in the remarks that is
|
||||||
did the same for the alternative version (see below) provided by the author (the
|
specifically for the USA rather than the world.
|
||||||
original can be seen in the author's remarks below).
|
|
||||||
|
|
||||||
|
|
||||||
## [1993/jonth](1993/jonth/jonth.c) ([README.md](1993/jonth/README.md]))
|
## [1993/jonth](1993/jonth/jonth.c) ([README.md](1993/jonth/README.md]))
|
||||||
|
|||||||
Reference in new issue
Block a user