From e4f39e2147987508486b39339e81fa090c231545 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Fri, 5 May 2023 04:46:37 -0700 Subject: [PATCH] Clarify a feature and clang issue in 1991/dds The clang issue does have an alternate version which I made a while back but I added a note earlier in the file that most likely it'll be needed for clang - depends on the default CFLAGS possibly but for macOS at least it does not work. I never tested linux but I probably should. --- 1991/dds/README.md | 12 +++++++++--- bugs.md | 5 +++-- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/1991/dds/README.md b/1991/dds/README.md index cd826b25a..434135dc7 100644 --- a/1991/dds/README.md +++ b/1991/dds/README.md @@ -20,6 +20,7 @@ make all ./a.out 2>/dev/null ``` + [Cody Boone Ferguson](/winners.html#Cody_Boone_Ferguson) fixed a segfault that prevented this entry from working at all and made an alternate version that works with `clang`. The alternate code, described below, is what is needed @@ -31,12 +32,17 @@ memory as a `char *s`. It's now a `char s[]`. Thank you Cody for your assistance! + +NOTE: for `clang` you'll likely have to use the alternate code described below. + ### INABIAF - it's not a bug it's a feature! :-) Please note that if the BASIC file cannot be opened for reading or the output -file cannot be opened for writing then this program will crash. These crashes -are a mild nuisance but are considered a feature not a bug. We challenge you to -fix it for learning if you wish. See also [bugs.md](/bugs.md). +file cannot be opened for writing then this program will very likely crash or do +something funny. + +These are a mild nuisance but are considered a feature not a bug. We challenge +you to fix it for learning if you wish. See also [bugs.md](/bugs.md). ## Try: diff --git a/bugs.md b/bugs.md index 80ed33b40..243b8deb5 100644 --- a/bugs.md +++ b/bugs.md @@ -647,8 +647,9 @@ This will be fixed in time but it's noted here for now. ## STATUS: INABIAF - please **DO NOT** fix If the BASIC file cannot be opened for reading or the output file cannot be -opened for writing the program will crash. This is not a bug but a feature. -Please do not fix this except for the challenge. +opened for writing the program will very likely crash or do something funny. +This is not a bug but a feature. Please do not fix this except for the +challenge to yourself. Please also note that for `clang` you have to use [dds.alt](1991/dds/dds.alt.c) not [dds.c](1991/dds/dds.c).