From 7832ef5e466fbf085efad6d701653af8ba59d986 Mon Sep 17 00:00:00 2001 From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com> Date: Tue, 4 Apr 2023 04:54:20 -0700 Subject: [PATCH] Fix to bugs.md for 1986/hague I by accident had left an incomplete sentence in the file (probably jumping to another entry when updating the file with multiple entries and then forgetting to go back .. numerous times). Fixed that and added a bit of information (or at least elaborated a bit?). --- bugs.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/bugs.md b/bugs.md index d54d717b3..d79c7e89b 100644 --- a/bugs.md +++ b/bugs.md @@ -298,10 +298,15 @@ the judges and shouldn't be fixed. ## [1986/hague](1986/hague/hague.c) ([README.md](1986/hague/README.md)) ## STATUS: uses gets() - change to fgets() if possible -This entry uses `gets()` which is unsafe. In particular the buffer size is 81. -`gets()` does not store the `'\n'` but it does store the `'\0'`. +This entry uses `gets()` which is unsafe. In particular the buffer size is a +mere 81 and it does not read a single string at command invocation but instead +until the program is terminated. This size can be increased to start out but it +would be better if it used `fgets()`. This will be addressed in time but is +noted here as a reminder. + +The way this entry is formed has made it not as simple as some of the others +that have been addressed. -The latter fact ## [1986/holloway](1986/holloway/holloway.c) ([README.md](1986/holloway/README.md)) ## STATUS: INABIAF - please **DO NOT** fix